Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Asserter with module-level assertion functions #1606

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

bartfeenstra
Copy link
Owner

No description provided.

@bartfeenstra bartfeenstra added enhancement New feature or request BC break Breaks backwards compatibility with existing integrations python Pull requests that update Python code labels Jun 22, 2024
@bartfeenstra bartfeenstra marked this pull request as ready for review June 22, 2024 00:05
Copy link

Uploaded Betty for commit 84abd84. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra merged commit 208fbf0 into 0.4.x Jun 22, 2024
9 checks passed
@bartfeenstra bartfeenstra deleted the assertion-functions branch June 22, 2024 01:09
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 93.26923% with 21 lines in your changes missing coverage. Please review.

Project coverage is 95.71%. Comparing base (643047d) to head (84abd84).
Report is 311 commits behind head on 0.4.x.

Files with missing lines Patch % Lines
betty/serde/load.py 89.82% 11 Missing and 6 partials ⚠️
betty/tests/test_config.py 33.33% 2 Missing ⚠️
betty/app/__init__.py 0.00% 1 Missing ⚠️
betty/tests/app/test___init__.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            0.4.x    #1606      +/-   ##
==========================================
+ Coverage   95.69%   95.71%   +0.01%     
==========================================
  Files         198      198              
  Lines       18823    18770      -53     
  Branches     3569     3569              
==========================================
- Hits        18013    17965      -48     
+ Misses        550      546       -4     
+ Partials      260      259       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bartfeenstra bartfeenstra restored the assertion-functions branch June 22, 2024 01:13
@bartfeenstra bartfeenstra deleted the assertion-functions branch June 24, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC break Breaks backwards compatibility with existing integrations enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant