Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add context param to all functions to handle deadlines/cancellation #30

Merged
merged 2 commits into from
Nov 23, 2024
Merged

add context param to all functions to handle deadlines/cancellation #30

merged 2 commits into from
Nov 23, 2024

Conversation

bartekpacia
Copy link
Owner

Problem

  1. Run fhomed
  2. Try to exit fhomed. CTRL+C does nothing. It never exits.

Root cause: fhomed library doesn't support graceful cancellation and deadline with package context.

@bartekpacia
Copy link
Owner Author

fixed:

Screen.Recording.2024-11-24.at.00.03.24.mov

@bartekpacia bartekpacia merged commit d6a3c63 into master Nov 23, 2024
1 check passed
@bartekpacia bartekpacia deleted the fix/introduce_context branch November 23, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bartekpacia