Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_latest_build_number: pass separate Hash for every service #7

Open
bartekpacia opened this issue Jun 16, 2022 · 0 comments
Open

Comments

@bartekpacia
Copy link
Owner

bartekpacia commented Jun 16, 2022

Thanks to this, number of arguments that get_latest_build_number takes will be reduced.

This:

build_number = get_new_build_number(
    bundle_identifier: ENV["APP_BUNDLE_ID"],
    package_name: ENV["APP_PACKAGE_NAME"],
    google_play_json_key_path: ENV["GOOGLE_PLAY_JSON_KEY_PATH"],
    firebase_json_key_path: ENV["FIREBASE_JSON_KEY_PATH"],
    firebase_app_ios: ENV["FIREBASE_APP_IOS"],
    firebase_app_android: ENV["FIREBASE_APP_ANDROID"],
  )

would become:

build_number = get_new_build_number(
  app_store: {:bundle_identifier => ENV["APP_BUNDLE_ID"]}
  google_play: {
    :package_name => ENV["APP_PACKAGE_NAME"],
    :json_key => ENV["GOOGLE_PLAY_JSON_KEY_PATH"],
  },
  firebase_app_distribution: {
    :json_key => ENV["FIREBASE_JSON_KEY_PATH"],
    :app_ios => ENV["FIREBASE_APP_IOS"],
    :app_android => ENV["FIREBASE_APP_ANDROID"],
  },
  app_center: nil, # or just leave it out
)

App Store

AppStoreBuildNumberAction

{
  :app_identifier: "pl.baftek.discoverRudy",
  :platform: "IOS",
  # TODO
}

Google Play

GooglePlayTrackVersionCodesAction

{
  :package_name,
  :track,
  :key,
  :issuer,
  :json_key,
  :json_key_data,
  :root_url,
  :timeout
}

TestFlight

LatestTestflightBuildNumberAction

Firebase App Distribution

FirebaseAppDistributionGetLatestReleaseAction

App Center

AppcenterFetchVersionNumberAction

{
  :api_token,
  :owner_name,
  :app_name,
  :version
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant