This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
Various improvements #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resulting deb files inside the "target" directory are not ignored by Git, therefore the output of "git status" is not clean since there are untracked changes. Everything under the "target" directory should be ignored, hence adding a ".gitignore" file for it. Also, the ".gitkeep" file is no longer necessary since the "target" directory will not be empty thanks to the ".gitignore" file we have added.
Hard coding versions in the README makes it harder to maintain, since every time the default versions change in the build script you need to remember to update the README. Instead, refer to the source where those versions are defined.
For those users who have both Docker and Podman installed, Docker will be used by default unless the new "-e" option is used to specify which container engine to use. For those users who only have Podman installed, the script will use it without having to specify a container engine.
Alacritty builds just fine for the arm64 architecture, and the Debian build tools are smart enough to detect the architecture of the host machine and build the deb packages only for that architecture.
|
@barnumbirr , sorry about the push force I did after creating the PR. I had to fix some typos in a commit message. The PR is now ready for review. Thanks. |
|
@barnumbirr , hello? |
|
@vincent-olivert-riera my bad, I completely forgot about this. Thank you for proposing your changes however I'm not sure I want to merge them: There's also an ongoing effort to create an actual Action for building Debian packages making all the shell scripts in this repository obsolete. |
|
No problem at all. Thanks for answering. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.