From 070b55a3ca1a1a2a1b3c681578928ed0b39e4d61 Mon Sep 17 00:00:00 2001 From: cecily_carver Date: Fri, 17 Jan 2025 15:44:38 -0800 Subject: [PATCH 1/2] chore: update sqlglot version and re-enable test. --- setup.py | 2 +- tests/test_query.py | 10 ++++------ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/setup.py b/setup.py index 02c053c..06de2fa 100644 --- a/setup.py +++ b/setup.py @@ -15,7 +15,7 @@ license="MIT", packages=find_packages(include=["mysql_mimic", "mysql_mimic.*"]), python_requires=">=3.6", - install_requires=["sqlglot>=18.6.0"], + install_requires=["sqlglot>=26.2.0"], extras_require={ "dev": [ "aiomysql", diff --git a/tests/test_query.py b/tests/test_query.py index e8f9c13..d976af8 100644 --- a/tests/test_query.py +++ b/tests/test_query.py @@ -778,12 +778,10 @@ async def test_describe_select( } ], ), - # Re-enable this test after sqlglot releases fix. - # PR with fix: https://github.com/tobymao/sqlglot/pull/4574 - # ( - # "select database(), schema(), left(user(),instr(concat(user(),'@'), '@')-1)", - # [{"DATABASE()": None, "SCHEMA()": None, "_col_2": "levon_helm"}], - # ), + ( + "select database(), schema(), left(user(),instr(concat(user(),'@'), '@')-1)", + [{"DATABASE()": None, "SCHEMA()": None, "_col_2": "levon_helm"}], + ), (queries.DATA_GRIP_PARAMETERS, []), ( queries.DATA_GRIP_TABLES, From 65d24a55169da8dcfc318ebbc6f970411a96f0e7 Mon Sep 17 00:00:00 2001 From: cecily_carver Date: Tue, 21 Jan 2025 12:30:59 -0600 Subject: [PATCH 2/2] Unpinning sqlglot version. --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 06de2fa..2608455 100644 --- a/setup.py +++ b/setup.py @@ -15,7 +15,7 @@ license="MIT", packages=find_packages(include=["mysql_mimic", "mysql_mimic.*"]), python_requires=">=3.6", - install_requires=["sqlglot>=26.2.0"], + install_requires=["sqlglot"], extras_require={ "dev": [ "aiomysql",