Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid creating unwanted virtual threads #43811

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Avoid creating unwanted virtual threads #43811

wants to merge 4 commits into from

Conversation

warunalakshitha
Copy link
Contributor

@warunalakshitha warunalakshitha commented Feb 11, 2025 •
edited
Loading

Purpose

Fixes #43694
Fixes #43761

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

HindujaB
HindujaB reviewed Feb 11, 2025
View reviewed changes
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/scheduling/Scheduler.java
parentStrand.yield();
}
return result;
Strand strand = Scheduler.getStrand();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the logic in callFunction and callMethod, shall we refactor the common parts to a function and reuse them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HindujaB HindujaB HindujaB left review comments

@sameerajayasoma sameerajayasoma Awaiting requested review from sameerajayasoma sameerajayasoma is a code owner

@hasithaa hasithaa Awaiting requested review from hasithaa hasithaa is a code owner

@gimantha gimantha Awaiting requested review from gimantha gimantha is a code owner

@MaryamZi MaryamZi Awaiting requested review from MaryamZi MaryamZi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@warunalakshitha @HindujaB