Fix bug with generated delete actions #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
pipex
force-pushed
the
delete-await-bug
branch
from
0a641c5 to
7d38ad8
Compare
|
I self-certify! |
pipex
commented
Dec 6, 2024
Tasks for delete operations can skip the deletion of the property being referenced because Mahler performs the delete operation after the successful execution of the given action. This fixes a bug where the deletion was happening too early before the inner function returned Change-type: patch
The calculation would before also consider library defaults, but either the defaults would not contribute to differentiating the id or in some cases, where the functions are overriden, it would erroneously generate the same id for two tasks that are different. Change-type: patch
Since making the `system` parameter readonly, the task definitions on the blocks tests were invalid.
Hopefully for the last time since fixing the task id calculation
pipex
force-pushed
the
delete-await-bug
branch
from
7d38ad8 to
0a559df
Compare
cywang117
approved these changes
Dec 6, 2024
cywang117
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks for delete operations can skip the deletion of the property being referenced because Mahler performs the delete operation after the successful execution of the given action. This fixes a bug where the deletion was happening too early before the inner function returned
Change-type: patch