Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Extract all hardcoded selectors to a single file and give a meaningful name #57

Open
tmigone opened this issue Jan 3, 2022 · 1 comment

Comments

@tmigone
Copy link
Contributor

tmigone commented Jan 3, 2022

Example: https://github.com/balena-io-playground/meetbot/blob/0a824f03066bb0d34b3d9cbb4501857436038604/src/meetbot/features/record.ts#L15

Would make it easier to maintain since you won't need to go looking for the strings (given that Google Meet UI changes often) and also a better notion of how "hacky" things are.

@tmigone tmigone mentioned this issue Jan 3, 2022
3 tasks
@20k-ultra
Copy link
Contributor

I think even better is to make these environment variables so that you don't need to rebuild your application or push code to update the bot. Ideally, the selectors are not HTML elements but rather a more robust mechanism that simply looks for an HTML element with the words "Record" when you hover over it...that's obviously much harder.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants