Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Gradle 8.4 #28

Merged
merged 13 commits into from
Jan 22, 2025
3 changes: 1 addition & 2 deletions .github/workflows/build-and-publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
jobs:
build-and-publish:
name: Java Gradle
uses: bakdata/ci-templates/.github/workflows/java-gradle-library.yaml@1.40.5
uses: bakdata/ci-templates/.github/workflows/java-gradle-library.yaml@1.55.0
with:
java-version: 17
secrets:
Expand All @@ -19,5 +19,4 @@ jobs:
signing-password: ${{ secrets.SONATYPE_SIGNING_PASSWORD }}
ossrh-username: ${{ secrets.SONATYPE_OSSRH_USERNAME }}
ossrh-password: ${{ secrets.SONATYPE_OSSRH_PASSWORD }}
github-username: ${{ secrets.GH_USERNAME }}
github-token: ${{ secrets.GH_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ on:
jobs:
java-gradle-release:
name: Java Gradle
uses: bakdata/ci-templates/.github/workflows/java-gradle-release.yaml@1.40.5
uses: bakdata/ci-templates/.github/workflows/java-gradle-release.yaml@1.55.0
with:
java-version: 17
release-type: "${{ inputs.release-type }}"
Expand Down
27 changes: 7 additions & 20 deletions build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
plugins {
// release
id("net.researchgate.release") version "3.0.2"
id("com.bakdata.sonar") version "1.1.11"
id("com.bakdata.sonatype") version "1.1.11"
id("org.hildan.github.changelog") version "1.12.1"
id("io.freefair.lombok") version "6.6.3" apply false
id("com.bakdata.release") version "1.4.0"
id("com.bakdata.sonar") version "1.4.0"
id("com.bakdata.sonatype") version "1.4.1"
id("io.freefair.lombok") version "8.4" apply false
}

allprojects {
Expand All @@ -31,12 +29,6 @@ configure<com.bakdata.gradle.SonatypeSettings> {
}
}

configure<org.hildan.github.changelog.plugin.GitHubChangelogExtension> {
githubUser = "bakdata"
futureVersionTag = findProperty("changelog.releaseVersion")?.toString()
sinceTag = findProperty("changelog.sinceTag")?.toString()
}

tasks.register<Javadoc>("javadoc") {
description = "Generates a global javadoc from all the modules"
options {
Expand All @@ -56,8 +48,9 @@ subprojects {
apply(plugin = "io.freefair.lombok")

configure<JavaPluginExtension> {
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
toolchain {
languageVersion = JavaLanguageVersion.of(11)
}
}

tasks.withType<Javadoc> {
Expand All @@ -80,9 +73,3 @@ subprojects {
"testImplementation"(group = "org.assertj", name = "assertj-core", version = "3.25.1")
}
}

release {
git {
requireBranch.set("master")
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
* MIT License
*
* Copyright (c) 2019 bakdata GmbH
* Copyright (c) 2025 bakdata
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -68,7 +68,8 @@ public class ConflictResolutionFusion<R> implements Fusion<R> {
@NonNull ConflictResolution<R, R> rootResolution;

@Getter(value = AccessLevel.PRIVATE, lazy = true)
@NonNull Map<@NonNull String, @NonNull Source> sourceByName =
@NonNull
Map<String, Source> sourceByName =
philipp94831 marked this conversation as resolved.
Show resolved Hide resolved
this.sources.stream().collect(Collectors.toMap(Source::getName, s -> s));

@Override
Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-all.zip
networkTimeout=10000
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists