-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): adds auth test key as auth is mandatory #187
Conversation
Authentication has been enabled by default in newer versions of Backstage. This adds a dummy secret so tests can continue as normal Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Hi all, it seems that CI tests are failing now due to auth being enabled by default in the newer versions of Backstage. I've added a test secret just so we populate that value (even though in production users would add it via a secret)so the tests can continue. There is a weird couple of test scenarios whereby the auth.keys are only needed for two of the CI test values files we're using - which we may have to look into. Either way, it seems to have got past the auth.key issue now and onto a techdocs issue. Not sure if any of you have seen this recently? When I install in a local kind cluster I also get the same error.
Welcome your thoughts! If I can get this PR merged relatively quickly, there are some updates I want to make to the Postgres sub chart versions and contributing docs whilst I have time over the bank holiday here in the UK! |
@ChrisJBurns I'll try to find time to test this out at some point this weekend |
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
@ChrisJBurns tests are good now! Added just a small suggestion |
auth: | ||
keys: | ||
# Is just a random b64 string for test purposes | ||
- secret: N4+P+zJrErWRUGm0ZbVVhX1ZC81aSP81 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI this won't be required anymore from the next version of Backstage as plugins will auto-configure service-to-service auth.
Of course let's keep it for now to get things unblocked
As long as you define the |
FYI the techdocs issue has been fixed, so from the next release the config won't be required either |
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
Cheers all! Apologies for late reply, have been away from keyboard! |
Description of the change
Authentication has been enabled by default in newer versions of Backstage. This adds a dummy secret so tests can continue as normal.
Existing or Associated Issue(s)
Fixes #186