fix: render ingress host also when using tls.

[kaos]

Description of the change

The ingress.host value is supported to use helm templating when used in the rules section of the Ingress resource, but when enabling TLS, it uses the host value un-rendered so it breaks if using template syntax.

This change renders the ingress.host for all uses, along with ingress.tls.secretName to make it more flexible as well.

Existing or Associated Issue(s)

Additional Information

Checklist

• Chart version bumped in Chart.yaml according to semver.
• Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
• JSON Schema generated.
• List tests pass for Chart using the Chart Testing tool and the ct lint command.

[kaos]

Hi, my first contribution here. 👋🏽

I can update the variable description and other todo items as needed, if this change is acceptable :)

Are there any contributing guidelines to follow to setup the pre-commit hooks and how to generate the JSON schema etc?

[vinzscam]

Välkommen @kaos, nice finding! 👏

Are there any contributing guidelines to follow to setup the pre-commit hooks and how to generate the JSON schema etc?

the hooks should run automagically, also your changes aren't affecting any values so all good 😄

just a couple of missing things to help CI checks pass:

• the chart version should be bumped to 1.9.1 in

  charts/charts/backstage/Chart.yaml

  Line 41 in 36f7e34

  version: 1.9.0

• your commits need to be signed https://github.com/backstage/backstage/blob/master/CONTRIBUTING.md#developer-certificate-of-origin

[kaos]

the hooks should run automagically

Not sure.. I installed pre-commit and then ran pre-commit install, and now the hooks run as they should ;)