Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: latest schema gen #164

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

smcavallo
Copy link
Contributor

Signed-off-by: smcavallo smcavallo@hotmail.com

Description of the change

There are no functional changes to the chart. The current CI build is failing.
It is due to newer properties being added when generating the json schema for values which are part of the api extensions.

The only change made in this PR is to regenerate the values schema.
Ex. python3 .pre-commit/jsonschema-dereference.py

Existing or Associated Issue(s)

Additional Information

Checklist

  • [X ] Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • [X ] JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

Signed-off-by: smcavallo <smcavallo@hotmail.com>
@smcavallo smcavallo requested a review from a team as a code owner February 7, 2024 14:31
@smcavallo smcavallo mentioned this pull request Feb 7, 2024
2 tasks
Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it makes sense, thank you!

@vinzscam vinzscam merged commit 92af33b into backstage:main Feb 21, 2024
3 checks passed
@smcavallo smcavallo deleted the latest-schema-gen branch February 21, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants