Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for pod affinity #162

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Conversation

smcavallo
Copy link
Contributor

@smcavallo smcavallo commented Jan 31, 2024

Signed-off-by: smcavallo smcavallo@hotmail.com

Description of the change

Adds support for pod affinity

Existing or Associated Issue(s)

Additional Information

output of helm template --values=values.yaml . before and after adding this feature is exactly the same

output after defining affinity in values works as expected:

      annotations:
        checksum/app-config: 44136fa355b3678a1146ad16f7e8649e94fb4fc21fe77e8310c060f61caaff8a
    spec:
      serviceAccountName: default
      affinity:
        nodeAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
            nodeSelectorTerms:
            - matchExpressions:
              - key: my-nodegroup
                operator: In
                values:
                - backstage
      volumes:

Checklist

  • [X ] Chart version bumped in Chart.yaml according to semver.
  • [X ] Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@smcavallo smcavallo requested a review from a team as a code owner January 31, 2024 13:24
Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smcavallo! 🙏
Please ensure that the schema changes are applied to values.schema.tmpl.json. There should be a pre-commit script that applies these changes to values.schema.json. If the script doesn't start automatically, you should be able to run it using python .pre-commit/jsonschema-dereference.py.

charts/backstage/values.schema.json Show resolved Hide resolved
Signed-off-by: smcavallo <smcavallo@hotmail.com>
Signed-off-by: smcavallo <smcavallo@hotmail.com>
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I had to rebase the branch in order to get the latest changes

thank you so much @smcavallo 🙏

@vinzscam vinzscam merged commit 36f7e34 into backstage:main Feb 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants