Skip to content

Commit

Permalink
fix: render ingress host also when using tls. (#167)
Browse files Browse the repository at this point in the history
* fix: render ingress host also when using tls.

Signed-off-by: Andreas Stenius <andreas.stenius@svenskaspel.se>

* Fix README

Signed-off-by: Andreas Stenius <andreas.stenius@svenskaspel.se>

---------

Signed-off-by: Andreas Stenius <andreas.stenius@svenskaspel.se>
  • Loading branch information
kaos authored Feb 23, 2024
1 parent 36f7e34 commit 5473e3f
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion charts/backstage/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ sources:
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.9.0
version: 1.9.1
2 changes: 1 addition & 1 deletion charts/backstage/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Backstage Helm Chart

[![Artifact Hub](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/backstage)](https://artifacthub.io/packages/search?repo=backstage)
![Version: 1.9.0](https://img.shields.io/badge/Version-1.9.0-informational?style=flat-square)
![Version: 1.9.1](https://img.shields.io/badge/Version-1.9.1-informational?style=flat-square)
![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)

A Helm chart for deploying a Backstage application
Expand Down
4 changes: 2 additions & 2 deletions charts/backstage/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ spec:
{{- if .Values.ingress.tls.enabled }}
tls:
- hosts:
- {{ .Values.ingress.host }}
secretName: {{ .Values.ingress.tls.secretName }}
- {{ include "common.tplvalues.render" ( dict "value" .Values.ingress.host "context" $ ) }}
secretName: {{ include "common.tplvalues.render" ( dict "value" .Values.ingress.tls.secretName "context" $ ) }}
{{- end }}
rules:
- host: {{ include "common.tplvalues.render" ( dict "value" .Values.ingress.host "context" $ ) }}
Expand Down

0 comments on commit 5473e3f

Please sign in to comment.