forked from opentensor/subtensor
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix do_set_weights to use commit_block in commit reveal #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to-publish Add token argument to the publish script
fix benchmarks + CI
…roxy Feat/root weights proxy
previously deployed to testnet with a different name for that index
Commit-Reveal 2 HotFixes Devnet
…-cost Reduce key swap cost to 0.1 TAO
bump spec version to 204
…t-9944-localnet alice default port from 9946 to 9944
bump devnet spec version to 205
testnet deploy 11-1-2024
olzhasar-reef
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to your changes,
I'm not sure why is this being converted to reference if it's still being dereferenced everywhere below, but I don't have any experience with Rust, maybe it's how it works:
let (commit_hash, commit_block) = maybe_commit
.as_ref()
.ok_or(Error::<T>::NoWeightsCommitFound)?;
…-testnet-mainnet Fix/merge conflicts testnet mainnet
finney deploy 11/5/2024
andreea-popescu-reef
force-pushed
the
blockfix
branch
from
November 7, 2024 06:57
b376333
to
a1d9d37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, do_set_weights sets last updated block to the current (reveal) block - this should be set to the weights commit block.
If not fixed, for concealment period > 1 tempo, the current implementation will unjustly distribute incentive whenever an uid re-registers between the commit and reveal block
Related Issue(s)
N/A
Type of Change
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctly