reset neuron data on registration #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreea-popescu-reef
force-pushed
the
fix-reg
branch
from
87be095 to
56a0328
Compare
mzukowski-reef
approved these changes
Jun 11, 2024
andreea-popescu-reef
force-pushed
the
fix-reg
branch
from
56a0328 to
4e4af9d
Compare
andreea-popescu-reef
force-pushed
the
fix-reg
branch
3 times, most recently
from
232f687 to
51fc171
Compare
…d_coldkey_swap_back_unit_test Junius/fix scheduled coldkey swap back unit test
Only run spec version check when the skip label doesn't exist
…-signed-extension
…d_coldkey_swap_back
release notes generator + spec version bump CI check fix + rust 1.81 fixes
Remove node requirement to build with `runtime-benchmarks`
andreea-popescu-reef
force-pushed
the
fix-reg
branch
from
5e425fb to
5e45f5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On neuron registration the trust, emission, consensus, incentive, dividends values as well as axon info associated with the assigned neuron_uid are inherited from the previous neuron. Thus for the first few blocks after registration these values will be wrong, then reset to zero and then get populated with the correct values for the newly registered neuron. This change resets these values on neuron registration.
Related Issue(s)
N/A
Type of Change
Breaking Change
no
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
N/A
Additional Notes
N/A