Skip to content

Commit

Permalink
Remove Depandabot Auto Merges and any CircleCI References
Browse files Browse the repository at this point in the history
1. We have multiple implementation of Dependabot, one of them did not
run for months, and the default one keeps failing. Also, Circle CI
is still being referenced for some reason in the Dependabot flow.

2. Rely of the PRs created by Depandabot, and will will do manual PR
reviews and merges for now.

3. When all of the CI is consolidated to Github Actions, we can
bring automatic Depandabot merges, in a cleaner way.

4. Remove any CircleCI References

Linear Issue: https://linear.app/expanso/issue/ENG-297/fix-dependabot-integration
Github Issue: #4656
  • Loading branch information
jamlo committed Oct 24, 2024
1 parent e0bcded commit 0c7b6c2
Show file tree
Hide file tree
Showing 5 changed files with 26 additions and 184 deletions.
39 changes: 23 additions & 16 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -1,18 +1,25 @@
version: 2
updates:
- package-ecosystem: "gomod"
directory: "/"
schedule:
interval: daily
labels:
- "lang/go"
- "th/dependencies"
open-pull-requests-limit: 1
- package-ecosystem: "pip"
directory: "/integration/"
schedule:
interval: daily
labels:
- "lang/python"
- "th/dependencies"
open-pull-requests-limit: 1
- package-ecosystem: "gomod"
directory: "/"
schedule:
interval: "daily"
labels:
- "lang/go"
- "dependabot/version-updates"
open-pull-requests-limit: 1
- package-ecosystem: "pip"
directory: "/integration/"
schedule:
interval: "daily"
labels:
- "lang/python"
- "dependabot/version-updates"
open-pull-requests-limit: 1
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "daily"
labels:
- "lang/github-actions"
- "dependabot/version-updates"
57 changes: 0 additions & 57 deletions .github/workflows/circleci.yml

This file was deleted.

39 changes: 0 additions & 39 deletions .github/workflows/dependabot-auto-merge.yml

This file was deleted.

58 changes: 0 additions & 58 deletions .github/workflows/dependabot.yml

This file was deleted.

17 changes: 3 additions & 14 deletions .github/workflows/testcontainers-integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,23 +13,12 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

# Detect Go version from test_integration/go.mod
- name: Detect Go version from test_integration/go.mod
id: detect-test-go-version
shell: bash
run: |
set -euo pipefail
go_version=$(grep '^go ' test_integration/go.mod | awk '{print $2}')
echo "Go version detected for integration tests: $go_version"
echo "GOLANG_TEST_VERSION=$go_version" >> $GITHUB_ENV
- name: Set up Go
- name: Install Golang
uses: actions/setup-go@v5
with:
go-version: ${{ env.GOLANG_TEST_VERSION }}
cache: true
go-version-file: go.work

- name: Run Go tests in integration test directory
shell: bash
Expand Down

0 comments on commit 0c7b6c2

Please sign in to comment.