Update composer (#93)

composer.json

@@ -47,7 +47,8 @@
             "composer/package-versions-deprecated": true,
             "symfony/flex": true,
             "symfony/runtime": true,
-            "dealerdirect/phpcodesniffer-composer-installer": true
+            "dealerdirect/phpcodesniffer-composer-installer": true,
+            "php-http/discovery": true
         },
         "optimize-autoloader": true,
         "preferred-install": {
@@ -60,11 +61,6 @@
             "App\\": "src/"
         }
     },
-    "autoload-dev": {
-        "psr-4": {
-            "App\\Tests\\": "tests/"
-        }
-    },
     "replace": {
         "symfony/polyfill-ctype": "*",
         "symfony/polyfill-iconv": "*",

src/Controller/HomeController.php

@@ -11,7 +11,7 @@
 
 final class HomeController
 {
-    public function __construct(readonly private Environment $twig)
+    public function __construct(private readonly Environment $twig)
     {
     }
 

src/Controller/Notification/MarkAsReadController.php

@@ -17,7 +17,7 @@
 final class MarkAsReadController
 {
     public function __construct(
-        readonly private NotificationService $notificationService,
+        private readonly NotificationService $notificationService,
     ) {
     }
 

src/Controller/Notification/ReloadController.php

@@ -18,8 +18,8 @@
 final class ReloadController
 {
     public function __construct(
-        readonly private NotificationService $notificationService,
-        readonly private Environment $twig
+        private readonly NotificationService $notificationService,
+        private readonly Environment $twig
     ) {
     }
 

src/Controller/OAuthController.php

@@ -12,7 +12,7 @@
 
 final class OAuthController extends AbstractController
 {
-    public function __construct(readonly private ClientRegistry $clientRegistry)
+    public function __construct(private readonly ClientRegistry $clientRegistry)
     {
     }
 

src/Controller/PullRequest/ListController.php

@@ -21,10 +21,10 @@
 final class ListController
 {
     public function __construct(
-        readonly private PullRequestLabelService $pullRequestLabelService,
-        readonly private PullRequestFilterService $pullRequestFilterService,
-        readonly private NotificationService $notificationService,
-        readonly private Environment $twig,
+        private readonly PullRequestLabelService $pullRequestLabelService,
+        private readonly PullRequestFilterService $pullRequestFilterService,
+        private readonly NotificationService $notificationService,
+        private readonly Environment $twig,
     ) {
     }
 

src/Controller/PullRequest/ReloadController.php

@@ -18,8 +18,8 @@
 final class ReloadController
 {
     public function __construct(
-        readonly private PullRequestFilterService $pullRequestFilterService,
-        readonly private Environment $twig
+        private readonly PullRequestFilterService $pullRequestFilterService,
+        private readonly Environment $twig
     ) {
     }
 

src/Controller/User/ConfigurationController.php

@@ -12,6 +12,7 @@
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpFoundation\Session\Session;
 use Symfony\Component\Routing\Annotation\Route;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
 use Symfony\Component\Security\Core\User\UserInterface;
@@ -20,9 +21,9 @@
 final class ConfigurationController
 {
     public function __construct(
-        readonly private Environment $twig,
-        readonly private UserRepository $repository,
-        readonly private UrlGeneratorInterface $router
+        private readonly Environment $twig,
+        private readonly UserRepository $repository,
+        private readonly UrlGeneratorInterface $router
     ) {
     }
 
@@ -38,7 +39,9 @@ public function __invoke(UserInterface $user, Request $request): Response
                 true,
             );
 
-            $request->getSession()->getFlashBag()->add('success', 'Configuration saved with success.');
+            /** @var Session $session */
+            $session = $request->getSession();
+            $session->getFlashBag()->add('success', 'Configuration saved with success.');
 
             return new RedirectResponse(
                 $this->router->generate('user_configuration')

src/Controller/User/DeleteController.php

@@ -8,6 +8,7 @@
 use App\Repository\UserRepository;
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Session\Session;
 use Symfony\Component\Routing\Annotation\Route;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
 use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
@@ -27,9 +28,11 @@ public function __construct(
     public function __invoke(Request $request, UserInterface $user): RedirectResponse
     {
         $this->userRepository->remove($user, true);
-        $this->tokenStorage->setToken(null);
+        $this->tokenStorage->setToken();
 
-        $request->getSession()->getFlashBag()->add('success', 'Your account was deleted with success.');
+        /** @var Session $session */
+        $session = $request->getSession();
+        $session->getFlashBag()->add('success', 'Your account was deleted with success.');
 
         return new RedirectResponse(
             $this->router->generate('home')

src/Event/EventSubscriber/ExceptionSubscriber.php

@@ -13,13 +13,14 @@
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpFoundation\Session\Session;
 use Symfony\Component\HttpKernel\Event\ExceptionEvent;
 use Symfony\Component\HttpKernel\KernelEvents;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
 
 final class ExceptionSubscriber implements EventSubscriberInterface
 {
-    public function __construct(readonly protected UrlGeneratorInterface $router)
+    public function __construct(protected readonly UrlGeneratorInterface $router)
     {
     }
 
@@ -51,7 +52,9 @@ public function githubException(ExceptionEvent $event): void
                     Response::HTTP_FORBIDDEN
                 );
             } else {
-                $event->getRequest()->getSession()->getFlashBag()->add(
+                /** @var Session $session */
+                $session = $event->getRequest()->getSession();
+                $session->getFlashBag()->add(
                     'error',
                     $event->getThrowable()->getMessage()
                 );
@@ -70,7 +73,9 @@ public function xhrException(ExceptionEvent $event): void
             return;
         }
 
-        $event->getRequest()->getSession()->getFlashBag()->add('error', $event->getThrowable()->getMessage());
+        /** @var Session $session */
+        $session = $event->getRequest()->getSession();
+        $session->getFlashBag()->add('error', $event->getThrowable()->getMessage());
         $event->setResponse(
             new RedirectResponse(
                 $this->router->generate('home')

src/Model/Doctrine/Type/AbstractEnumType.php

@@ -15,9 +15,7 @@ abstract public static function getEnumClass(): string;
     // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter
     public function getSQLDeclaration(array $column, AbstractPlatform $platform): string
     {
-        if (false === \array_key_exists('type', $column)
-            || false === $column['type'] instanceof AbstractEnumType
-        ) {
+        if (false === \array_key_exists('type', $column)) {
             throw new \InvalidArgumentException('Wrong enum column type.');
         }
 

src/Security/Authenticator/GithubAuthenticator.php

@@ -13,6 +13,7 @@
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpFoundation\Session\Session;
 use Symfony\Component\Routing\RouterInterface;
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
 use Symfony\Component\Security\Core\Exception\AuthenticationException;
@@ -24,10 +25,10 @@
 final class GithubAuthenticator extends OAuth2Authenticator implements AuthenticationEntryPointInterface
 {
     public function __construct(
-        readonly private ClientRegistry $clientRegistry,
-        readonly private RouterInterface $router,
-        readonly private UserRepository $userRepository,
-        readonly private LoggerInterface $logger,
+        private readonly ClientRegistry $clientRegistry,
+        private readonly RouterInterface $router,
+        private readonly UserRepository $userRepository,
+        private readonly LoggerInterface $logger,
     ) {
     }
 
@@ -83,7 +84,9 @@ function () use ($accessToken, $client): User {
     // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter
     public function onAuthenticationSuccess(Request $request, TokenInterface $token, string $firewallName): ?Response
     {
-        $request->getSession()->getFlashBag()->add('success', 'Github OAuth connection success.');
+        /** @var Session $session */
+        $session = $request->getSession();
+        $session->getFlashBag()->add('success', 'Github OAuth connection success.');
 
         return new RedirectResponse($this->router->generate('home'));
     }
@@ -93,7 +96,10 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio
     {
         $error = strtr($exception->getMessageKey(), $exception->getMessageData());
 
-        $request->getSession()->getFlashBag()->add('error', $error);
+        /** @var Session $session */
+        $session = $request->getSession();
+        $session->getFlashBag()->add('error', $error);
+
         $this->logger->error(
             'Github OAuth connection failed',
             [