Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure crates into _model structure. #202

Merged
merged 19 commits into from
Feb 5, 2025

Conversation

azriel91
Copy link
Owner

@azriel91 azriel91 commented Feb 1, 2025

Still need to move the peace_cmd (the CmdCtx builder types), and then the *Cmd types out of peace_rt.

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 81.41593% with 21 lines in your changes missing coverage. Please review.

Project coverage is 88.43%. Comparing base (17278be) to head (f4aca08).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
crate/rt_model/src/item_wrapper.rs 0.00% 7 Missing ⚠️
crate/rt_model/src/params_specs_serializer.rs 0.00% 6 Missing ⚠️
...e/webi_output/src/outcome_info_graph_calculator.rs 0.00% 2 Missing ⚠️
items/blank/src/blank_item.rs 0.00% 1 Missing ⚠️
items/file_download/src/file_download_item.rs 0.00% 1 Missing ⚠️
items/sh_cmd/src/sh_cmd_item.rs 0.00% 1 Missing ⚠️
items/tar_x/src/tar_x_item.rs 0.00% 1 Missing ⚠️
workspace_tests/src/mock_item.rs 0.00% 1 Missing ⚠️
workspace_tests/src/vec_copy_item.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   88.38%   88.43%   +0.04%     
==========================================
  Files         432      430       -2     
  Lines       45220    45137      -83     
==========================================
- Hits        39969    39916      -53     
+ Misses       5251     5221      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azriel91 azriel91 marked this pull request as ready for review February 5, 2025 20:27
@azriel91 azriel91 merged commit a28b0cf into main Feb 5, 2025
13 checks passed
@azriel91 azriel91 deleted the maintenance/187/move-crates-to-model-structure branch February 5, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant