-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure crates into _model
structure.
#202
Merged
azriel91
merged 19 commits into
main
from
maintenance/187/move-crates-to-model-structure
Feb 5, 2025
Merged
Restructure crates into _model
structure.
#202
azriel91
merged 19 commits into
main
from
maintenance/187/move-crates-to-model-structure
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… out of default. This allows `workspace_tests` to run with `cargo nextest run --workspace`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
==========================================
+ Coverage 88.38% 88.43% +0.04%
==========================================
Files 432 430 -2
Lines 45220 45137 -83
==========================================
- Hits 39969 39916 -53
+ Misses 5251 5221 -30 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*_model
and*_rt_model
crate structure #187.Still need to move the
peace_cmd
(theCmdCtx
builder types), and then the*Cmd
types out ofpeace_rt
.