skin color fix, error fix connected with custom array types in es6 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en no animation is set on the supplied track index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing skins doesn't set proper color on slots, so I just wrote a quick fix by setting the attachment rgb to skin's rgb in setAttachment. I believe it can done in better way. In addition I noticed that in _attachAll function slot.data.attachmentName should be used instead of slot.attachment.name for proper functionality. I'm writing my code in es6 standard where typeof(Float32Arary) caused an error, so I just removed them, and exported the class in the end which I do with all of your plugins .. it would be nice if you accept those changes for es6 but even if you wouldn't it's not critical.