Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add aderyn to github actions #210

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

ci: add aderyn to github actions #210

wants to merge 25 commits into from

Conversation

TanvirDeol
Copy link

@TanvirDeol TanvirDeol commented Jan 25, 2025

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (432449d) to head (bd41dcb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #210   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files          48       48           
  Lines         754      754           
  Branches      154      154           
=======================================
  Hits          742      742           
  Misses          3        3           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/aderyn.yaml Show resolved Hide resolved
.github/workflows/aderyn.yaml Outdated Show resolved Hide resolved
.github/workflows/aderyn.yaml Outdated Show resolved Hide resolved
.github/workflows/aderyn.yaml Outdated Show resolved Hide resolved
.github/workflows/aderyn.yaml Outdated Show resolved Hide resolved
@TanvirDeol TanvirDeol marked this pull request as ready for review January 27, 2025 00:33
@TanvirDeol TanvirDeol requested a review from a team as a code owner January 27, 2025 00:33
.github/actions/aderyn/action.yaml Show resolved Hide resolved
- name: Generate Aderyn Report
id: run_aderyn
run: |
aderyn --output report.md . 2>&1 | tee aderyn_output.log
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was because of the rust-cache, which is unnecessary so I removed it. I initially added it thinking it would speed things up.

aderyn_version:
description: "Aderyn version to install"
required: true
default: "v0.3.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the latest by default?

Copy link
Author

@TanvirDeol TanvirDeol Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an issue with the newer version, the installation method was more tedious, something like this: 1efe386, so I reverted to the last version where the installation wasn't giving me problems.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated to the latest and it works now, using the same Github install method

.github/actions/aderyn/action.yaml Outdated Show resolved Hide resolved
.github/workflows/aderyn.yaml Outdated Show resolved Hide resolved
on:
pull_request:
branches:
- ci/aderyn-analysis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants