Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQS Listener EventBridgeMessage annotation and converter #1307

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

frjonsen
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Core goal was to add a new annotation, @EventBridgeMessage, as well as the corresponding converter and argument resolver. I took the liberty of splitting out common functionality SnsMessageConverter to an abstract WrappedMessageConverter to reduce duplication.

💡 Motivation and Context

Further context in this issue: #1272

💚 How did you test it?

Added tests similar to those of the @SnsNotificationMessage. The test resource eventBridgeMessage is taken partially from https://docs.aws.amazon.com/AmazonS3/latest/userguide/ev-events.html, though the payload was written by hand to match the POJO.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

@github-actions github-actions bot added component: sqs SQS integration related issue type: documentation Documentation or Samples related issue labels Dec 19, 2024
@frjonsen
Copy link
Contributor Author

I was unsure what to fill in as version, in the places they were mentioned. I wrote 3.3.0 as that seemed to be the next unreleased version. Should this be changed to something else, or will it be updated once it is determined which version this would be included in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: sqs SQS integration related issue type: documentation Documentation or Samples related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant