Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abort method for S3OutputStream for ability to cancel the upload midway through #1221

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Abort method for S3OutputStream for ability to cancel the upload midway through #1221

merged 2 commits into from
Sep 19, 2024

Conversation

zhemaituk
Copy link
Contributor

@zhemaituk zhemaituk commented Sep 18, 2024 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

S3OutputStream#abort method added, allowing to cancel the upload and clean up the temporal resources.

💡 Motivation and Context

#1199

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
    javadoc updated. Is it sufficient?
  • All tests passing
  • No breaking changes

🔮 Next steps

@zhemaituk zhemaituk mentioned this pull request Sep 18, 2024
Closed
@maciejwalkowiak maciejwalkowiak added this to the 3.3.0 milestone Sep 19, 2024
@maciejwalkowiak maciejwalkowiak added component: s3 S3 integration related issue type: enhancement Smaller enhancement in existing integration labels Sep 19, 2024
@maciejwalkowiak maciejwalkowiak merged commit 2f78149 into awspring:main Sep 19, 2024
4 checks passed
@maciejwalkowiak
Copy link
Contributor

Thanks @zhemaituk!

@maciejwalkowiak maciejwalkowiak modified the milestones: 3.3.0, 3.3.0 M1 Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejwalkowiak maciejwalkowiak maciejwalkowiak approved these changes

@MatejNedic MatejNedic Awaiting requested review from MatejNedic MatejNedic is a code owner

@tomazfernandes tomazfernandes Awaiting requested review from tomazfernandes tomazfernandes is a code owner

Assignees
No one assigned
Labels
component: s3 S3 integration related issue type: enhancement Smaller enhancement in existing integration
Projects
None yet
Milestone
3.3.0 M1
Development

Successfully merging this pull request may close these issues.
2 participants
@zhemaituk @maciejwalkowiak