Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parameter Store] Strip leading dot from imported parameters #923

Closed
matthias-seibert-tng opened this issue Oct 25, 2023 · 3 comments
Closed
Labels
component: parameter-store Parameter Store integration related issue type: documentation Documentation or Samples related issue
Milestone

Comments

@matthias-seibert-tng
Copy link

Type: Bug

Component: Parameter Store

Describe the bug
The library adds a leading dot (.) to imported variables, when using the setup as suggested in the readme (spring.config.import=aws-parameterstore:/config/spring)

This leads to problems when importing variables stored in a nested hierarchy. For example, if a variable stored at /config/spring/my/message, it is imported as .my.message, and cannot be accessed via @Value("${my.message}").

Changing the config to spring.config.import=aws-parameterstore:/config/spring/ resolves this problem, but it would be a nice feature to strip the leading dot in the library.

@MatejNedic
Copy link
Member

Hey @matthias-seibert-tng , since we are loading by path it is important to end with the / .
It only makes sense since you want all on the path.

@matthias-seibert-tng
Copy link
Author

I can understand that, but then it would be great if you could update the docs, because in the examples there, there is no slash at the end. See this screenshot:

Screenshot

@maciejwalkowiak maciejwalkowiak added component: parameter-store Parameter Store integration related issue type: documentation Documentation or Samples related issue labels Nov 6, 2023
@maciejwalkowiak maciejwalkowiak added this to the 3.0.4 milestone Nov 6, 2023
@maciejwalkowiak maciejwalkowiak removed this from the 3.0.4 milestone Dec 10, 2023
@maciejwalkowiak maciejwalkowiak added this to the 3.1.1 milestone Mar 9, 2024
@maciejwalkowiak
Copy link
Contributor

Closed in #1086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: parameter-store Parameter Store integration related issue type: documentation Documentation or Samples related issue
Projects
None yet
Development

No branches or pull requests

3 participants