Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Conflict Warning #899

Closed
aonurozcan opened this issue Sep 27, 2023 · 4 comments
Closed

Potential Conflict Warning #899

aonurozcan opened this issue Sep 27, 2023 · 4 comments
Labels
component: sqs SQS integration related issue status: waiting-for-feedback Waiting for feedback from issuer

Comments

@aonurozcan
Copy link

Type: Bug

Component: SQS

Describe the bug
Potential conflict between commons-logging:jar in spring-cloud-aws-starter-sqs dependency and Spring Framework.

It shows a warning on startup like below.

Standard Commons Logging discovery in action with spring-jcl: please remove commons-logging.jar from classpath in order to avoid potential conflicts

Sample
Spring Boot version: 3.1.3
Spring Cloud Aws Version: 3.0.2

@tomazfernandes
Copy link
Contributor

Hey @aonurozcan, thanks for bringing this up.

Not sure what to do about this - would you be able to provide a sample app that reproduces it so I can take a look?

Thanks.

@tomazfernandes tomazfernandes added component: sqs SQS integration related issue status: waiting-for-feedback Waiting for feedback from issuer labels Oct 12, 2023
@aonurozcan
Copy link
Author

Hey @tomazfernandes

I'm sorry I just realized that it has nothing to do with awspring. It's related to spring-boot-starter-test and lombok.

Thanks

@aonurozcan aonurozcan closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2023
@asenchuk
Copy link

I had the same issue. commons-logging comes with aws sdk so I had to exclude it from all (I have 2) spring-cloud-aws starters

./gradlew dependencyInsight --configuration productionRuntimeClasspath --dependency commons-logging:commons-logging

> Task :dependencyInsight
commons-logging:commons-logging:1.2
  Variant runtime:
    | Attribute Name                 | Provided     | Requested    |
    |--------------------------------|--------------|--------------|
    | org.gradle.status              | release      |              |
    | org.gradle.category            | library      | library      |
    | org.gradle.libraryelements     | jar          | jar          |
    | org.gradle.usage               | java-runtime | java-runtime |
    | org.gradle.dependency.bundling |              | external     |
    | org.gradle.jvm.environment     |              | standard-jvm |
    | org.gradle.jvm.version         |              | 17           |

commons-logging:commons-logging:1.2
\--- org.apache.httpcomponents:httpclient:4.5.13
     \--- software.amazon.awssdk:apache-client:2.21.12
          +--- io.awspring.cloud:spring-cloud-aws-dependencies:3.1.0
          |    \--- productionRuntimeClasspath
          +--- software.amazon.awssdk:ses:2.21.12
          |    +--- io.awspring.cloud:spring-cloud-aws-dependencies:3.1.0 (*)
          |    \--- io.awspring.cloud:spring-cloud-aws-ses:3.1.0
          |         +--- io.awspring.cloud:spring-cloud-aws-dependencies:3.1.0 (*)
          |         \--- io.awspring.cloud:spring-cloud-aws-starter-ses:3.1.0
          |              +--- productionRuntimeClasspath (requested io.awspring.cloud:spring-cloud-aws-starter-ses)
          |              \--- io.awspring.cloud:spring-cloud-aws-dependencies:3.1.0 (*)
          \--- software.amazon.awssdk:s3:2.21.12
               +--- io.awspring.cloud:spring-cloud-aws-dependencies:3.1.0 (*)
               +--- io.awspring.cloud:spring-cloud-aws-s3:3.1.0
               |    +--- io.awspring.cloud:spring-cloud-aws-dependencies:3.1.0 (*)
               |    \--- io.awspring.cloud:spring-cloud-aws-starter-s3:3.1.0
               |         +--- productionRuntimeClasspath (requested io.awspring.cloud:spring-cloud-aws-starter-s3)
               |         \--- io.awspring.cloud:spring-cloud-aws-dependencies:3.1.0 (*)
               \--- io.awspring.cloud:spring-cloud-aws-s3-cross-region-client:3.1.0
                    +--- io.awspring.cloud:spring-cloud-aws-dependencies:3.1.0 (*)
                    \--- io.awspring.cloud:spring-cloud-aws-starter-s3:3.1.0 (*)
implementation ('io.awspring.cloud:spring-cloud-aws-starter-s3') {
	exclude group: 'commons-logging', module: 'commons-logging'
}
implementation ('io.awspring.cloud:spring-cloud-aws-starter-ses') {
	exclude group: 'commons-logging', module: 'commons-logging'
}

@tomazfernandes
Copy link
Contributor

Seems like an issue with AWS SDK then? @maciejwalkowiak, anything we should do about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: sqs SQS integration related issue status: waiting-for-feedback Waiting for feedback from issuer
Projects
None yet
Development

No branches or pull requests

3 participants