Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spring-cloud-aws-ses: allow setting fromArn on SendRawEmail operation #1025

Closed
thomas-burko opened this issue Jan 22, 2024 · 0 comments
Closed

spring-cloud-aws-ses: allow setting fromArn on SendRawEmail operation #1025

thomas-burko opened this issue Jan 22, 2024 · 0 comments
Labels
component: ses SES integration related issue type: enhancement Smaller enhancement in existing integration
Milestone
3.1.1

Comments

@thomas-burko
Copy link
Contributor

Type: Feature

Is your feature request related to a problem? Please describe.

Similar to #1006 it would be nice to also specify the fromArn on a per client basis.

It seems like perfectly fine use case that if we use SimpleEmailServiceJavaMailSender and as such SES client we can control which config set is used. It is impossible because org.springframework.cloud.aws.mail.simplemail.SimpleEmailServiceJavaMailSender#send(javax.mail.internet.MimeMessage...) does not expose any way to inject fromArn into SendRawEmailRequest object coming from AWS SDK.

Describe the solution you'd like

I want to be able to specify fromArn.

Describe alternatives you've considered

Subclassing SimpleEmailServiceJavaMailSender and overriding entire send method.
thomas-burko added a commit to thomas-burko/spring-cloud-aws that referenced this issue Jan 22, 2024
@thomas-burko
SES fromArn is configurable via properties Fixes awspringGH-1025
f64622d
thomas-burko added a commit to thomas-burko/spring-cloud-aws that referenced this issue Jan 22, 2024
@thomas-burko
SES fromArn is configurable via properties Fixes awspringGH-1025
69ede20
@thomas-burko thomas-burko mentioned this issue Jan 22, 2024
Merged
9 tasks
@maciejwalkowiak maciejwalkowiak added this to the 3.1.1 milestone Mar 10, 2024
@maciejwalkowiak maciejwalkowiak added component: ses SES integration related issue type: enhancement Smaller enhancement in existing integration labels Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ses SES integration related issue type: enhancement Smaller enhancement in existing integration
Projects
None yet
Milestone
3.1.1
Development

No branches or pull requests
2 participants
@maciejwalkowiak @thomas-burko