Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add preset traffic source attributes #62

Merged
merged 3 commits into from
Apr 10, 2024
Merged

feat: add preset traffic source attributes #62

merged 3 commits into from
Apr 10, 2024

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. add preset traffic source attributes
  2. add _app_install_channel, event _value and _currency preset attributes

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Apr 10, 2024
@zhu-xiaowei zhu-xiaowei requested a review from zxkane April 10, 2024 09:57
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (7912ee4) to head (78473c2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   96.64%   96.81%   +0.16%     
==========================================
  Files          35       35              
  Lines        2119     1664     -455     
==========================================
- Hits         2048     1611     -437     
+ Misses         71       53      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit 2dd236c into main Apr 10, 2024
5 checks passed
@zxkane zxkane deleted the traffic-source branch April 10, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants