Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile validation #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix profile validation #214

wants to merge 1 commit into from

Conversation

rusowyler
Copy link

@rusowyler rusowyler commented Mar 14, 2023

Description of changes:

  • Correct the validation for the profile

    You can use letters, numbers, hyphens ( - ), and underscores ( _ ), but no spaces.

  • Added additional profile name validation alternatives to the tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution under the terms of your choice.

@calvin-c-stellantis
Copy link

Has this PR been merged? If not could you please merge?

Thanks a lot.

@iwamot
Copy link

iwamot commented May 9, 2023

I too wasted some time due to underscores not being allowed.

It seems to me that this PR should be merged immediately to avoid user confusion.

By the way, aws-sdk-java-v2 defines the following:

private static final Pattern VALID_IDENTIFIER = Pattern.compile("^[A-Za-z0-9_\\-/.%@:\\+]*$");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants