feat: enable endpoint discovery (and Timestream Query and Timestream Write) #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajtodd
approved these changes
Jul 17, 2023
| @@ -197,11 +190,6 @@ fun fileToService(applyFilters: Boolean): (File) -> AwsService? = { file: File - | |||
| null | |||
| } | |||
|
|
|||
| applyFilters && filename in disabledServices -> { | |||
There was a problem hiding this comment.
nit: I would maybe keep the ability to disable services, it may come in handy at some point.
lauzadis
approved these changes
Jul 17, 2023
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Closes smithy-kotlin#146, closes #800
Description of changes
This change pulls in upstream changes for endpoint discovery and enables Timestream Query and Timestream Write. Also adds new end-to-end tests which verify that endpoint discovery works properly for the two new services.
Companion PR: smithy-kotlin#887
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.