Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: track upstream observability API changes #974

Merged
merged 9 commits into from
Jul 18, 2023
Merged

Conversation

aajtodd
Copy link
Collaborator

@aajtodd aajtodd commented Jul 7, 2023

Issue #

upstream: smithy-lang/smithy-kotlin#886

Description of changes

Incremental PRs already reviewed:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aajtodd aajtodd marked this pull request as ready for review July 7, 2023 19:15
@aajtodd aajtodd requested a review from a team as a code owner July 7, 2023 19:15
{
"id": "5b1a8324-02da-4281-bd23-81c565eed973",
"type": "misc",
"description": "**BREAKING**: Refactor observability API and configuration."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Recommend including link to breaking discussion post.

@@ -7,13 +7,13 @@ kotlin.mpp.enableCompatibilityMetadataVariant=true
org.gradle.jvmargs=-Xmx6g -XX:MaxMetaspaceSize=2G

# sdk
sdkVersion=0.28.2-SNAPSHOT
sdkVersion=0.28.0-SNAPSHOT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 0.29.0?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah now it should be

@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aajtodd aajtodd merged commit a9a87f4 into main Jul 18, 2023
11 of 13 checks passed
@aajtodd aajtodd deleted the observability branch July 18, 2023 15:46
@aajtodd aajtodd mentioned this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants