-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: track upstream observability API changes #974
Conversation
{ | ||
"id": "5b1a8324-02da-4281-bd23-81c565eed973", | ||
"type": "misc", | ||
"description": "**BREAKING**: Refactor observability API and configuration." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Recommend including link to breaking discussion post.
gradle.properties
Outdated
@@ -7,13 +7,13 @@ kotlin.mpp.enableCompatibilityMetadataVariant=true | |||
org.gradle.jvmargs=-Xmx6g -XX:MaxMetaspaceSize=2G | |||
|
|||
# sdk | |||
sdkVersion=0.28.2-SNAPSHOT | |||
sdkVersion=0.28.0-SNAPSHOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 0.29.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah now it should be
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Issue #
upstream: smithy-lang/smithy-kotlin#886
Description of changes
Incremental PRs already reviewed:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.