feat: smoke tests #1427
Merged
feat: smoke tests #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… smoke-tests-trait
… smoke-tests-trait
0marperez
added
the
no-changelog
|
A new generated diff is ready to view. |
lauzadis
approved these changes
Oct 3, 2024
| val sdkRootDir = System.getProperty("user.dir") + "/../../../" | ||
| val runner = GradleRunner.create() | ||
| .withProjectDir(File(sdkRootDir)) | ||
| .withArguments(listOf("-Paws.kotlin.native=false", ":tests:codegen:smoke-tests:services:$service:smokeTest")) |
This comment has been minimized.
This comment has been minimized.
ianbotsf
approved these changes
Oct 3, 2024
| @@ -43,7 +43,7 @@ private fun runSmokeTests(service: String, envVars: Map<String, String> = emptyM | |||
| val sdkRootDir = System.getProperty("user.dir") + "/../../../" | |||
| val runner = GradleRunner.create() | |||
| .withProjectDir(File(sdkRootDir)) | |||
| .withArguments(":tests:codegen:smoke-tests:services:$service:smokeTest") | |||
| .withArguments(listOf("-Paws.kotlin.native=false", ":tests:codegen:smoke-tests:services:$service:smokeTest")) | |||
There was a problem hiding this comment.
Nit: A vararg overload of withArguments exists so listOf could be removed.
.withArguments("-Paws.kotlin.native=false", ":tests:codegen:smoke-tests:services:$service:smokeTest")| @@ -43,7 +43,7 @@ private fun runSmokeTests(service: String, envVars: Map<String, String> = emptyM | |||
| val sdkRootDir = System.getProperty("user.dir") + "/../../../" | |||
| val runner = GradleRunner.create() | |||
| .withProjectDir(File(sdkRootDir)) | |||
| .withArguments(":tests:codegen:smoke-tests:services:$service:smokeTest") | |||
| .withArguments(listOf("-Paws.kotlin.native=false", ":tests:codegen:smoke-tests:services:$service:smokeTest")) | |||
There was a problem hiding this comment.
Question: Do we have a task or something that tracks removing all the places we've disabled native builds? If not, I suggest we add a FIXME or something else here to increase the likelihood we remember to remove this once Kotlin/Native is ready.
There was a problem hiding this comment.
That's a good point. I added a subtask to our Kotlin Native task so we remember.
|
|
A new generated diff is ready to view. |
Affected ArtifactsChanged in size
|
0marperez
added a commit
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
Reintroduces support for smoke tests which was reverted in #1421. With the addition of smoke test e2e tests running with
aws.kotlin.nativeturned off.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.