Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add integration test for empty S3 object #1015

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

ianbotsf
Copy link
Contributor

Issue #

Closes #1014

Description of changes

Adds an S3 end-to-end test to validate that empty GetObject responses are correctly validated.

Companion PR: smithy-lang/smithy-kotlin#915

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ianbotsf ianbotsf added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Aug 11, 2023
@ianbotsf ianbotsf requested a review from a team as a code owner August 11, 2023 21:09
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ianbotsf ianbotsf merged commit aaf5001 into main Aug 14, 2023
12 of 13 checks passed
@ianbotsf ianbotsf deleted the fix-empty-body branch August 14, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 ClientException: HttpBody type is not supported
3 participants