Update Errors in Mqtt Client #268
Conversation
| @@ -23,6 +23,20 @@ public struct CRTError: Equatable { | |||
| self.name = String(cString: aws_error_name(self.code)) | |||
| } | |||
|
|
|||
| public init<T: BinaryInteger>(code: T, context: String?) { | |||
There was a problem hiding this comment.
Do we still need the context string if we are generating errors from crt swift?
In the areas that are currently using context, it seems like error logging would be more appropriate. Unless we are not going to generate logs from aws-crt-swift.
There was a problem hiding this comment.
I eventually decide to keep the context, as the logging for Swift is not there yet.
There was a problem hiding this comment.
Unsure whether we need the context string in CommonRuntimeError. That can be changed later if we decide against it. Looks solid otherwise.
On a side note, once we do this, we need to update common to reflect the error range that aws-crt-swift is taking. (ah, you've already done it =P)
There was a problem hiding this comment.
Added comments. I am willing to agree to disagree here. I still feel that this PR doesn't have a strong enough use case for Swift errors. The added complexity might not justify the benefits, which seem limited to a slightly better error name that might not be significant for users.
This reverts commit 6f566ec.
Issue #, if available:
Description of changes:
unwrapfunction to unwrap OptionalBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.