Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data type for password #265

Merged
merged 339 commits into from
Jul 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
339 commits
Select commit Hold shift + click to select a range
1048a48
mqttclient
xiazhvera Mar 11, 2024
14662fc
Merge branch 'mqtt5-enums' of https://github.com/awslabs/aws-crt-swif…
xiazhvera Mar 11, 2024
fb0e43b
rename onPublishCallback to onPublishReceived
sbSteveK Mar 20, 2024
8c3eb2a
test types
xiazhvera Mar 24, 2024
5245401
Merge branch 'mqtt5-enums' of https://github.com/awslabs/aws-crt-swif…
xiazhvera Mar 24, 2024
66edc53
process options
xiazhvera Mar 25, 2024
b2f2ca7
disable test
xiazhvera Mar 25, 2024
ea16ba9
Merge branch 'iot' of https://github.com/awslabs/aws-crt-swift into t…
xiazhvera Mar 25, 2024
048c795
Merge branch 'iot' of https://github.com/awslabs/aws-crt-swift into t…
xiazhvera Mar 25, 2024
12fccfb
Merge branch 'iot' of https://github.com/awslabs/aws-crt-swift into t…
xiazhvera Mar 25, 2024
93a13df
fix rawdata
xiazhvera Mar 25, 2024
3f49dd8
Merge branch 'iot' of https://github.com/awslabs/aws-crt-swift into m…
xiazhvera Mar 25, 2024
016d344
WIP quick merge fix
xiazhvera Mar 25, 2024
e64591c
convert time interval
xiazhvera Mar 25, 2024
11ccb48
formatting
sbSteveK Mar 25, 2024
ee5f4a8
Merge branch 'mqtt5client_creation' into mqtt5-connect
sbSteveK Mar 25, 2024
d2f4ba0
wip sample
sbSteveK Mar 25, 2024
28eaaf0
update raw data with helper function
xiazhvera Mar 25, 2024
f7917ce
update publish packet binding
xiazhvera Mar 25, 2024
f25b1df
pass valid value
xiazhvera Mar 25, 2024
ee2c669
setup minimal mqttclient test
xiazhvera Mar 26, 2024
472bbfe
remove callback changes
xiazhvera Mar 26, 2024
231162b
setup mqtt5 callbacks
xiazhvera Mar 26, 2024
7927ce1
setup client options
xiazhvera Mar 26, 2024
054841e
Merge branch 'mqtt5client_creation' of https://github.com/awslabs/aws…
xiazhvera Mar 26, 2024
d0e5994
fix warning
xiazhvera Mar 26, 2024
9c30789
update callback setup
xiazhvera Mar 26, 2024
d70f569
sample
sbSteveK Mar 26, 2024
a752906
Merge branch 'mqtt5client_creation' into mqtt5-connect
sbSteveK Mar 26, 2024
455f9ef
lint
sbSteveK Mar 26, 2024
0c7160d
lint
sbSteveK Mar 26, 2024
b221249
fix swiftlint
xiazhvera Mar 26, 2024
1fe2961
create client in test sample
sbSteveK Mar 26, 2024
678df48
fixing format
xiazhvera Mar 26, 2024
bfffb29
merge conflicts
sbSteveK Mar 26, 2024
bcf174b
Merge branch 'tls_options' of https://github.com/awslabs/aws-crt-swif…
xiazhvera Mar 26, 2024
c559642
fix whitespace
xiazhvera Mar 26, 2024
fe7cea8
Merge branch 'mqtt5client_creation' of https://github.com/awslabs/aws…
xiazhvera Mar 26, 2024
b152a4e
merge with callbacks branch
sbSteveK Mar 26, 2024
3744417
manual merge
sbSteveK Mar 26, 2024
c35edec
tls context should be optional
xiazhvera Mar 26, 2024
ededc2b
Merge branch 'mqtt5client_creation' of https://github.com/awslabs/aws…
xiazhvera Mar 26, 2024
f9da5d9
test direct connect
sbSteveK Mar 26, 2024
9dfc8aa
Merge branch 'mqtt5callbacks' into mqtt5-connect
sbSteveK Mar 26, 2024
b654eb7
fix user properties and subscription identifier
xiazhvera Mar 27, 2024
65bbdaa
Merge branch 'mqtt5client_creation' of https://github.com/awslabs/aws…
xiazhvera Mar 27, 2024
6d5ec7d
add disconnect callback and tests
xiazhvera Mar 27, 2024
1938a5a
add disconnect
xiazhvera Mar 28, 2024
fdcf9b2
test wip
sbSteveK Mar 28, 2024
1403008
Merge branch 'mqtt5callbacks' into mqtt5-connect
sbSteveK Mar 28, 2024
590dca8
wip
sbSteveK Mar 28, 2024
cd0ad93
sample wip update
sbSteveK Mar 29, 2024
1d219b2
wip
sbSteveK Mar 29, 2024
0987f26
bones of lifecycle event processing
sbSteveK Mar 29, 2024
104d462
re-add commented out TLS test
sbSteveK Mar 29, 2024
e38ec26
format of test above
sbSteveK Mar 29, 2024
f6ea50e
missing empty line?
sbSteveK Mar 29, 2024
f875ef7
functioning lifecycle event connection success callback
sbSteveK Mar 29, 2024
17da86c
feedback and added utils
sbSteveK Apr 1, 2024
e1360a4
setup for close function
xiazhvera Apr 2, 2024
74c4d87
Merge branch 'mqtt5client_creation' of https://github.com/awslabs/aws…
xiazhvera Apr 2, 2024
95e7499
save for merge
sbSteveK Apr 2, 2024
67101cd
merge with mqtt5callbacks branch
sbSteveK Apr 2, 2024
4e96fe1
bound Connack and Negotiated Settings
sbSteveK Apr 2, 2024
fcef989
fixes
sbSteveK Apr 2, 2024
a98a662
Merge branch 'iot' of https://github.com/awslabs/aws-crt-swift into m…
xiazhvera Apr 2, 2024
164c9ff
Merge branch 'mqtt5client_creation' of https://github.com/awslabs/aws…
xiazhvera Apr 2, 2024
0ffb8d0
fix merge error
xiazhvera Apr 2, 2024
aa75032
remaining lifecycle events
sbSteveK Apr 3, 2024
87e6ab9
cleanup
sbSteveK Apr 3, 2024
d2b2bb4
more cleanup
sbSteveK Apr 3, 2024
fd3f329
clean up
sbSteveK Apr 3, 2024
baf897a
move raw to native building into individual classes
sbSteveK Apr 3, 2024
41d66bf
expected native members will fatalError
sbSteveK Apr 4, 2024
4783bc5
Convert UserProperties
sbSteveK Apr 4, 2024
391e66b
Merge branch 'mqtt5client_creation' of https://github.com/awslabs/aws…
xiazhvera Apr 4, 2024
e55a393
clean up and error reporting
sbSteveK Apr 4, 2024
e622349
utils update
sbSteveK Apr 4, 2024
56c25b9
formatting
sbSteveK Apr 4, 2024
8fb7f01
formatting
sbSteveK Apr 4, 2024
a3b0df8
simplification
sbSteveK Apr 4, 2024
801be13
remove test sample
sbSteveK Apr 4, 2024
8dc96bf
formatting
sbSteveK Apr 4, 2024
079dff7
add DisconnectPacket swift -> native
sbSteveK Apr 4, 2024
5c9a519
Merge branch 'mqtt5-connect' into mqtt5-connect-tests
sbSteveK Apr 4, 2024
7a9be3a
initial connect test framework
sbSteveK Apr 5, 2024
9ba7aab
Merge branch 'mqtt5callbacks' into mqtt5-connect
sbSteveK Apr 5, 2024
64aa7d7
Merge branch 'mqtt5-connect' into mqtt5-connect-tests
sbSteveK Apr 5, 2024
81266bb
test more tests
sbSteveK Apr 8, 2024
324bc9b
fix name
sbSteveK Apr 8, 2024
db049d7
fix name again
sbSteveK Apr 8, 2024
f5e3b01
fixes
sbSteveK Apr 8, 2024
eaa5620
tls change
sbSteveK Apr 8, 2024
749c27d
http proxy test
sbSteveK Apr 8, 2024
d9767ae
declare name in log of missing env variable
sbSteveK Apr 8, 2024
2c85b33
make SocketOptions and Bootstrap optional in MqttClientOptions
sbSteveK Apr 8, 2024
8107801
TLSContextOptions doesn't throw on default
sbSteveK Apr 8, 2024
6e98fb9
remove common error
xiazhvera Apr 8, 2024
fd90c96
Merge branch 'iot' of https://github.com/awslabs/aws-crt-swift into m…
xiazhvera Apr 8, 2024
ca39e31
fix swift space
xiazhvera Apr 8, 2024
a0183ee
Merge branch 'mqtt5client_creation' of https://github.com/awslabs/aws…
xiazhvera Apr 8, 2024
975bc95
add rwlock to callback core
xiazhvera Apr 8, 2024
82fad92
connect maximum test
sbSteveK Apr 9, 2024
4766548
Merge branch 'iot' of https://github.com/awslabs/aws-crt-swift into m…
xiazhvera Apr 9, 2024
b2330a6
latest
sbSteveK Apr 9, 2024
28b31e4
merge with latest callbacks branch
sbSteveK Apr 9, 2024
0817915
Merge branch 'mqtt5-connect' into mqtt5-connect-tests
sbSteveK Apr 9, 2024
ee8ef12
lint
sbSteveK Apr 9, 2024
31dd62b
Merge branch 'mqtt5-connect' into mqtt5-connect-tests
sbSteveK Apr 9, 2024
209f0b0
instantiate byte buf for user property once and only once
sbSteveK Apr 9, 2024
9cb55fd
Merge branch 'mqtt5-connect-tests' of https://github.com/awslabs/aws-…
xiazhvera Apr 9, 2024
7cb1270
rename user data
xiazhvera Apr 9, 2024
d1a41ef
update subscribe packet
xiazhvera Apr 9, 2024
f5f8103
subscribePacket, subscribe operation
xiazhvera Apr 10, 2024
c54068c
onPublishRecieved
xiazhvera Apr 10, 2024
703b0d5
update test & cleanup format
xiazhvera Apr 10, 2024
6c18384
update doc comments
xiazhvera Apr 10, 2024
7ba5da6
kick ci
xiazhvera Apr 11, 2024
d97466b
update semaphore
xiazhvera Apr 11, 2024
ae20f4e
wip publish
xiazhvera Apr 15, 2024
81058e8
wip subscribe test
xiazhvera Apr 15, 2024
046f8a5
kick ci
xiazhvera Apr 15, 2024
336f801
test disabel publish signal
xiazhvera Apr 15, 2024
12f3c1b
disable publish view
xiazhvera Apr 15, 2024
1f594fc
fix correlation data
xiazhvera Apr 15, 2024
23853eb
publish signal
xiazhvera Apr 15, 2024
7045e40
Merge branch 'mqtt5Operations' of https://github.com/awslabs/aws-crt-…
xiazhvera Apr 15, 2024
c11c09a
test publish
xiazhvera Apr 15, 2024
114e3f3
clean up guard and correlation data
xiazhvera Apr 15, 2024
7cdffbe
Merge branch 'mqtt5Operations' of https://github.com/awslabs/aws-crt-…
xiazhvera Apr 15, 2024
bfb38d8
wait on sub
xiazhvera Apr 15, 2024
5c25aa8
fix lint space
xiazhvera Apr 15, 2024
58c32ff
Merge branch 'mqtt5Operations' of https://github.com/awslabs/aws-crt-…
xiazhvera Apr 15, 2024
4a43598
fix warnings
xiazhvera Apr 15, 2024
7037a4a
fix unchanged var
xiazhvera Apr 15, 2024
85a01cc
Merge branch 'mqtt5Operations' into mqtt5_publish
xiazhvera Apr 15, 2024
2d34cfc
improve publish
xiazhvera Apr 16, 2024
888c400
use convert from native
xiazhvera Apr 16, 2024
351b30c
merge fixes
sbSteveK Apr 16, 2024
f45aea7
cr changes
sbSteveK Apr 17, 2024
69e5cf5
lint
sbSteveK Apr 17, 2024
5c75d4f
test fix
sbSteveK Apr 17, 2024
121dd78
Merge branch 'mqtt5-connect' into mqtt5-connect-tests
sbSteveK Apr 17, 2024
5a0ed95
no support for makeMTLS on non macOS and Linux
sbSteveK Apr 17, 2024
3bf4cc1
connection failure tests
sbSteveK Apr 17, 2024
3c60e83
rearrange test funcs
sbSteveK Apr 17, 2024
8a1bf5c
negotiated settings tests
sbSteveK Apr 17, 2024
64371c2
remove comments
sbSteveK Apr 17, 2024
97d4f56
lint
sbSteveK Apr 17, 2024
437e9cc
port failure can result in two different failure paths
sbSteveK Apr 17, 2024
6936f8b
merge with iot
sbSteveK Apr 17, 2024
1b7ce01
merge fixes
sbSteveK Apr 17, 2024
73421c0
Merge branch 'mqtt5-connect-tests' of https://github.com/awslabs/aws-…
xiazhvera Apr 17, 2024
37c3300
Merge branch 'mqtt5_callback_lock' of https://github.com/awslabs/aws-…
xiazhvera Apr 17, 2024
8579aaf
Merge branch 'mqtt5Operations' of https://github.com/awslabs/aws-crt-…
xiazhvera Apr 17, 2024
af77e16
publish test
xiazhvera Apr 17, 2024
044e43c
skip function
sbSteveK Apr 18, 2024
69bb54b
Add test function for skipping if not mac/linux
sbSteveK Apr 18, 2024
3807f00
renamed skip platform func
sbSteveK Apr 18, 2024
7d0f011
try
sbSteveK Apr 18, 2024
ec20946
try
sbSteveK Apr 18, 2024
3f8d267
test skip message
sbSteveK Apr 18, 2024
b8fc1f8
move skip function to shared area
sbSteveK Apr 18, 2024
f6a2784
test removal of platform specific tls creation funcs
sbSteveK Apr 18, 2024
947de54
makeTLS changes
sbSteveK Apr 18, 2024
bbed001
comment
sbSteveK Apr 18, 2024
17c0503
no clue why makeTLS was working before without returning
sbSteveK Apr 18, 2024
21f292c
Merge branch 'mqtt5-connect-tests' into mqtt5_callback_lock
sbSteveK Apr 18, 2024
62ec53a
merge with base branch
sbSteveK Apr 18, 2024
dc559f7
add more options to subscribe packet creation
sbSteveK Apr 18, 2024
f979871
attempt to add timeout
sbSteveK Apr 18, 2024
2a41795
unsubscribe and unsuback bindings
sbSteveK Apr 19, 2024
6dca6d4
small description changes
sbSteveK Apr 19, 2024
73b595e
remove print statements
sbSteveK Apr 19, 2024
581bdef
Merge branch 'mqtt5_callback_lock' into mqtt5Operations
sbSteveK Apr 19, 2024
ea9389b
Merge branch 'mqtt5Operations' of https://github.com/awslabs/aws-crt-…
xiazhvera Apr 19, 2024
8a6fa5e
line edits
sbSteveK Apr 19, 2024
ec4f7e9
merge with mqtt5_publish
sbSteveK Apr 19, 2024
0303994
lint
sbSteveK Apr 19, 2024
bb7c1bd
clean up publish
xiazhvera Apr 19, 2024
c423f28
try await on publish
xiazhvera Apr 19, 2024
7f0bfa9
reason code conversion changes
sbSteveK Apr 22, 2024
c3425ea
tests
sbSteveK Apr 23, 2024
7e85c63
Merge branch 'iot' of https://github.com/awslabs/aws-crt-swift into m…
xiazhvera Apr 23, 2024
eaba0e5
Merge branch 'mqtt5Operations' of https://github.com/awslabs/aws-crt-…
xiazhvera Apr 23, 2024
7307da8
boilerplate reduction
sbSteveK Apr 23, 2024
ddb06d5
fix lint
sbSteveK Apr 24, 2024
a487d99
more lint changes and cr changes
sbSteveK Apr 24, 2024
91503ba
identifier names need to be excluded
sbSteveK Apr 24, 2024
27cd454
improve operations
xiazhvera Apr 24, 2024
f5b6fbc
lint
sbSteveK Apr 24, 2024
441cdb5
release continuationCore on failed unsub
sbSteveK Apr 24, 2024
24d1800
Merge branch 'mqtt5_publish' into mqtt5-unsubscribe
sbSteveK Apr 24, 2024
d1d27a1
naming and errors
sbSteveK Apr 24, 2024
cabdcad
manually input port 8883 because builder doesn't set the env for it
sbSteveK Apr 24, 2024
280a427
fixes and payloadAsString returns nil on empty payload
sbSteveK Apr 24, 2024
70de8f8
op failure tests
sbSteveK Apr 24, 2024
667924c
Error operation and qos1 tests
sbSteveK Apr 24, 2024
78bb822
more tests
sbSteveK Apr 25, 2024
63be820
cleanup
sbSteveK Apr 25, 2024
adc84ac
more cleanup
sbSteveK Apr 25, 2024
058814e
cleanup
sbSteveK Apr 25, 2024
300e43d
cleanup warnings
sbSteveK Apr 25, 2024
a874025
WIP dispatch queue test
xiazhvera Apr 28, 2024
83b3985
negative value validation
sbSteveK Apr 29, 2024
94bd1ea
remove Int from enums that don't have underlying int values
sbSteveK Apr 29, 2024
f19b56a
warnings cleanup in tests
sbSteveK Apr 29, 2024
36a6907
minimal cleanup/reduction
sbSteveK Apr 30, 2024
0b70fd4
merge with mqtt5-enum-refactor
sbSteveK Apr 30, 2024
1e016b9
Merge branch 'mqtt5-enum-refactor' of https://github.com/awslabs/aws-…
xiazhvera May 1, 2024
4b6e567
clean up
xiazhvera May 1, 2024
1224c0a
fix compile
xiazhvera May 2, 2024
c4f4c8d
Merge branch 'iot' of https://github.com/awslabs/aws-crt-swift into m…
xiazhvera May 6, 2024
8c05130
fix merge
xiazhvera May 6, 2024
8f9af28
clean up merge
xiazhvera May 7, 2024
8f0ed92
use weak self
xiazhvera May 7, 2024
965177b
test around publish received
xiazhvera May 8, 2024
a2bd1b8
add lock to all operations
xiazhvera May 8, 2024
fdb57cf
setup async callbacks
xiazhvera May 8, 2024
ae7634a
clean up mqtt client tests
xiazhvera May 13, 2024
67807ab
revert pubsub test
xiazhvera May 13, 2024
be77cdd
Merge branch 'iot' of https://github.com/awslabs/aws-crt-swift into m…
xiazhvera May 13, 2024
9f8a027
fix merge
xiazhvera May 13, 2024
0e58e24
formatting
xiazhvera May 13, 2024
7a0d900
await on async operations
xiazhvera May 13, 2024
74f0444
add comments for close()
xiazhvera May 13, 2024
bf10b08
add close() for mqtt tests
xiazhvera May 13, 2024
979d775
fix websocket callback
xiazhvera May 13, 2024
64afcfe
clean up comments
xiazhvera May 13, 2024
01f10d7
add optional convertion util
xiazhvera May 13, 2024
e71722e
update error handling
xiazhvera May 15, 2024
003aabf
fix data type for password
xiazhvera May 15, 2024
6d782bc
update cr
xiazhvera May 15, 2024
d40e004
add back client core
xiazhvera May 20, 2024
aff8999
remove unnecessary close
xiazhvera May 20, 2024
ff4c679
remove close
xiazhvera May 20, 2024
4f5a76b
remove debug print
xiazhvera May 20, 2024
c58d4b5
fix stop function
xiazhvera May 20, 2024
6f119d9
fix wrong var name
xiazhvera May 20, 2024
ccafa25
clean up tests
xiazhvera May 20, 2024
8867080
lint fix
xiazhvera May 20, 2024
fbd6822
update cr
xiazhvera Jun 5, 2024
78888e4
revert help function
xiazhvera Jun 5, 2024
300da0c
Merge branch 'mqtt5_deadlock' of https://github.com/awslabs/aws-crt-s…
xiazhvera Jun 5, 2024
8437d06
Merge branch 'swift_error' of https://github.com/awslabs/aws-crt-swif…
xiazhvera Jun 5, 2024
554c9b5
update crt error
xiazhvera Jun 11, 2024
e377204
fix lint
xiazhvera Jun 11, 2024
fcaeb29
Merge branch 'mqtt_error' of https://github.com/awslabs/aws-crt-swift…
xiazhvera Jun 11, 2024
364d8d2
Merge branch 'iot' of https://github.com/awslabs/aws-crt-swift into d…
xiazhvera Jul 18, 2024
ffea020
fix compile error
xiazhvera Jul 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions Source/AwsCommonRuntimeKit/mqtt/Mqtt5Options.swift
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
public let username: String?

/// Opaque binary data that the server may use for client authentication and authorization.
public let password: String?
public let password: Data?

/// A time interval, in whole seconds, that the client requests the server to persist this connection's MQTT session state for. Has no meaning if the client has not been configured to rejoin sessions. Must be non-zero in order to successfully rejoin a session. If the responding CONNACK contains a session expiry property value, then that is the negotiated session expiry value. Otherwise, the session expiry sent by the client is the negotiated value.
public let sessionExpiryInterval: TimeInterval?
Expand Down Expand Up @@ -84,7 +84,7 @@
public init (keepAliveInterval: TimeInterval? = nil,
clientId: String? = nil,
username: String? = nil,
password: String? = nil,
password: Data? = nil,
sessionExpiryInterval: TimeInterval? = nil,
requestResponseInformation: Bool? = nil,
requestProblemInformation: Bool? = nil,
Expand Down Expand Up @@ -151,11 +151,11 @@
_willDelayIntervalSec,
self.receiveMaximum,
self.maximumPacketSize) { sessionExpiryIntervalSecPointer,
requestResponseInformationPointer,

Check warning on line 154 in Source/AwsCommonRuntimeKit/mqtt/Mqtt5Options.swift

View workflow job for this annotation

GitHub Actions / lint

Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace (closure_parameter_position)
requestProblemInformationPointer,

Check warning on line 155 in Source/AwsCommonRuntimeKit/mqtt/Mqtt5Options.swift

View workflow job for this annotation

GitHub Actions / lint

Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace (closure_parameter_position)
willDelayIntervalSecPointer,

Check warning on line 156 in Source/AwsCommonRuntimeKit/mqtt/Mqtt5Options.swift

View workflow job for this annotation

GitHub Actions / lint

Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace (closure_parameter_position)
receiveMaximumPointer,

Check warning on line 157 in Source/AwsCommonRuntimeKit/mqtt/Mqtt5Options.swift

View workflow job for this annotation

GitHub Actions / lint

Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace (closure_parameter_position)
maximumPacketSizePointer in

Check warning on line 158 in Source/AwsCommonRuntimeKit/mqtt/Mqtt5Options.swift

View workflow job for this annotation

GitHub Actions / lint

Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace (closure_parameter_position)

raw_connect_options.session_expiry_interval_seconds = sessionExpiryIntervalSecPointer
raw_connect_options.request_response_information = requestResponseInformationPointer
Expand All @@ -176,11 +176,12 @@
raw_connect_options.user_property_count = userProperties!.count
raw_connect_options.user_properties = UnsafePointer<aws_mqtt5_user_property>(cUserProperties)
}
return withOptionalByteCursorPointerFromStrings(
username, password) { cUsernamePointer, cPasswordPointer in
return withOptionalByteCursorPointerFromString(username) { cUsernamePointer in
raw_connect_options.username = cUsernamePointer
raw_connect_options.password = cPasswordPointer
return body(raw_connect_options)
return withAWSByteCursorPointerFromOptionalData(to: password) { cPasswordPointer in
raw_connect_options.password = cPasswordPointer
return body(raw_connect_options)
}
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions Test/AwsCommonRuntimeKitTests/mqtt/Mqtt5ClientTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ class Mqtt5ClientTests: XCBaseTestCase {
let connectOptions = MqttConnectOptions(
clientId: createClientId(),
username: inputUsername,
password: inputPassword
password: inputPassword.data(using: .utf8)
)

let clientOptions = MqttClientOptions(
Expand Down Expand Up @@ -579,7 +579,7 @@ class Mqtt5ClientTests: XCBaseTestCase {
let connectOptions = MqttConnectOptions(
clientId: createClientId(),
username: inputUsername,
password: inputPassword
password: inputPassword.data(using: .utf8)
)

let clientOptions = MqttClientOptions(
Expand Down
Loading