Bind SHA256/SHA1/MD5 Update/Finalize API #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayaffe
approved these changes
Jan 25, 2024
|
Could we also include adding update() and finalize() to MD5 hashing? |
waahm7
changed the title
| @@ -5,6 +5,64 @@ import struct Foundation.Data | |||
| import struct Foundation.TimeInterval | |||
| import AwsCCal | |||
|
|
|||
| public enum HashAlgorithm { | |||
There was a problem hiding this comment.
are we exposing crc's differently already?
There was a problem hiding this comment.
Yeah, CRC32/CRC32C has a different API https://github.com/awslabs/aws-crt-swift/blob/main/Source/AwsCommonRuntimeKit/crt/Checksums.swift#L11.
| } | ||
| } | ||
|
|
||
| public func finalize(truncate: Int = 0) throws -> Data { |
There was a problem hiding this comment.
nit: truncate almost sounds like a boolean on whether result needs to be truncated or not, but in reality its the number of bytes to truncate to. better name?
There was a problem hiding this comment.
Thanks, updated to truncateTo
DmitriyMusatkin
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.