Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind Sha1, crc32 and crc32c #209

Merged
merged 10 commits into from
Nov 7, 2023
Merged

Bind Sha1, crc32 and crc32c #209

merged 10 commits into from
Nov 7, 2023

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Nov 6, 2023

Issue: #198

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Package.swift Show resolved Hide resolved
Copy link
Contributor

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix & ship

Package.swift Show resolved Hide resolved
Source/AwsCommonRuntimeKit/crt/Checksums.swift Outdated Show resolved Hide resolved
Source/AwsCommonRuntimeKit/crt/Checksums.swift Outdated Show resolved Hide resolved
@waahm7 waahm7 requested a review from jbelkins November 7, 2023 17:46
Copy link
Contributor

@jbelkins jbelkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question

@waahm7 waahm7 merged commit 2b5fc3b into main Nov 7, 2023
9 checks passed
@waahm7 waahm7 deleted the bind-checksums branch November 7, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants