Skip to content

Commit

Permalink
Improves documentation in Package.swift regarding lack of CPU flags. (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
waahm7 authored Jan 22, 2024
1 parent 21498e0 commit c6682ce
Showing 1 changed file with 7 additions and 13 deletions.
20 changes: 7 additions & 13 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ var awsCCommonPlatformExcludes = ["source/android",
"source/linux/system_info.c",
"bin/"] + excludesFromAll

// includes arch/generic
// includes arch/generic because the SwiftPM doesn't like the necessary compiler flags.
awsCCommonPlatformExcludes.append("source/arch/intel")
awsCCommonPlatformExcludes.append("source/arch/arm")
#if !os(Windows)
Expand Down Expand Up @@ -143,21 +143,15 @@ var awsCChecksumsExcludes = [

// swift never uses Microsoft Visual C++ compiler
awsCChecksumsExcludes.append("source/intel/visualc")
// TODO: enable hardware acceleration https://github.com/awslabs/aws-sdk-swift/issues/867
// #if arch(arm64)
//// includes source/arm
//// TODO: look at the compiler flag in C
// awsCChecksumsExcludes.append("source/intel")
// awsCChecksumsExcludes.append("source/generic")
// #elseif arch(x86_64) || arch(i386)
//// include src/intel/asm
// awsCChecksumsExcludes.append("source/arm")
// awsCChecksumsExcludes.append("source/generic")
// #else

// Hardware accelerated checksums are disabled because SwiftPM doesn't like the necessary compiler flags.
// We can add it once SwiftPM has the necessary support for CPU flags or builds C libraries
// using CMake.
// See: https://github.com/apple/swift-package-manager/issues/4555
// Also, see issue: https://github.com/awslabs/aws-sdk-swift/issues/867 before enabling hardware accelerated checksums.
// includes source/generic
awsCChecksumsExcludes.append("source/arm")
awsCChecksumsExcludes.append("source/intel")
// #endif

//////////////////////////////////////////////////////////////////////
/// aws-c-sdkutils
Expand Down

0 comments on commit c6682ce

Please sign in to comment.