Fix MonitoringOptions (#242)

awslabs · Mar 15, 2024 · 459da1e · 459da1e
1 parent d0674a3
commit 459da1e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/Source/AwsCommonRuntimeKit/http/HTTPMonitoringOptions.swift b/Source/AwsCommonRuntimeKit/http/HTTPMonitoringOptions.swift
@@ -3,15 +3,19 @@
 import AwsCHttp
 
 public struct HTTPMonitoringOptions: CStruct {
-    /// Minimum amount of throughput, in bytes per second, for a connection to be considered healthy
+
+    /// Minimum amount of throughput, in bytes per second, for a connection to be considered healthy. 
+    /// Must be at least one.
     public var minThroughputBytesPerSecond: UInt64
 
     /// How long, in seconds, a connection is allowed to be unhealthy before getting shut down.
-    /// Must be at least two
+    /// Must be at least one.
     public var allowableThroughputFailureInterval: UInt32
 
-    init(minThroughputBytesPerSecond: UInt64 = 0,
-         allowableThroughputFailureInterval: UInt32 = 2) {
+    public init(
+        minThroughputBytesPerSecond: UInt64,
+        allowableThroughputFailureInterval: UInt32
+    ) {
         self.minThroughputBytesPerSecond = minThroughputBytesPerSecond
         self.allowableThroughputFailureInterval = allowableThroughputFailureInterval
     }

diff --git a/Test/AwsCommonRuntimeKitTests/http/HTTPClientConnectionOptionsTests.swift b/Test/AwsCommonRuntimeKitTests/http/HTTPClientConnectionOptionsTests.swift
@@ -29,7 +29,7 @@ class HTTPClientConnectionOptionsTests: XCBaseTestCase {
                 proxyEnvSettings: HTTPProxyEnvSettings(envVarType: HTTPProxyEnvType.disable),
                 socketOptions: SocketOptions(socketType: .stream),
                 tlsOptions: tlsOptions,
-                monitoringOptions: HTTPMonitoringOptions(minThroughputBytesPerSecond: 10),
+                monitoringOptions: HTTPMonitoringOptions(minThroughputBytesPerSecond: 10, allowableThroughputFailureInterval: 3),
                 maxConnections: 10,
                 enableManualWindowManagement: true,
                 maxConnectionIdleMs: 100,