Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GetObject request with Range Header to Skip HeadRequest - Part 3 #397

Merged
merged 45 commits into from
Dec 28, 2023
Merged

Refactor GetObject request with Range Header to Skip HeadRequest - Part 3 #397

merged 45 commits into from
Dec 28, 2023

Commits on Dec 20, 2023

  1. Parse the user provided range header

    @waahm7
    waahm7 committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    6b052a1 View commit details
    Browse the repository at this point in the history

  2. Add logic to skip head request given start range

    @waahm7
    waahm7 committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    43bc2a4 View commit details
    Browse the repository at this point in the history

  3. remove allocator unusued

    @waahm7
    waahm7 committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    5521490 View commit details
    Browse the repository at this point in the history

  4. remove allocator

    @waahm7
    waahm7 committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    3854912 View commit details
    Browse the repository at this point in the history

  5. Force headObject by missing start range

    @waahm7
    waahm7 committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    49d8d51 View commit details
    Browse the repository at this point in the history

  6. convert to size_t

    @waahm7
    waahm7 committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    273d2d8 View commit details
    Browse the repository at this point in the history

  7. fix empty file logic

    @waahm7
    waahm7 committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    a001a3f View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Fix mock test

    @waahm7
    waahm7 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    0ad2a44 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refactor-empty-file' into refactor-ranged-get-object

    @waahm7
    waahm7 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    edf6b9b View commit details
    Browse the repository at this point in the history

  3. Update comment

    @waahm7
    waahm7 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    745c3bb View commit details
    Browse the repository at this point in the history

  4. Update comments

    @waahm7
    waahm7 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    a65473c View commit details
    Browse the repository at this point in the history

  5. lint fix

    @waahm7
    waahm7 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    6849e21 View commit details
    Browse the repository at this point in the history

  6. update comment

    @waahm7
    waahm7 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    824fe27 View commit details
    Browse the repository at this point in the history

  7. Fix todos

    @waahm7
    waahm7 committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    bf0571c View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Add the startRange>endRange case todos

    @waahm7
    waahm7 committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    118cadc View commit details
    Browse the repository at this point in the history

  2. Refactor the parsing logic

    @waahm7
    waahm7 committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    99903d5 View commit details
    Browse the repository at this point in the history

  3. remove todo

    @waahm7
    waahm7 committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    2e244c2 View commit details
    Browse the repository at this point in the history

  4. Fix test

    @waahm7
    waahm7 committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    8c8dfa9 View commit details
    Browse the repository at this point in the history

  5. Refactor object_size vs content_length

    @waahm7
    waahm7 committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    cda3be3 View commit details
    Browse the repository at this point in the history

  6. update comments

    @waahm7
    waahm7 committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    b4ad24f View commit details
    Browse the repository at this point in the history

  7. Add parse range header tests

    @waahm7
    waahm7 committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    939c395 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2023

  1. First part size alignment

    @waahm7
    waahm7 committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    8a2b2ab View commit details
    Browse the repository at this point in the history

  2. Remove alignment, as it doesn't appear to affect the benchmarks.

    @waahm7
    waahm7 committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    9be9cb0 View commit details
    Browse the repository at this point in the history

  3. Clean up

    @waahm7
    waahm7 committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    50b4f22 View commit details
    Browse the repository at this point in the history

  4. Make sure CI is working even with alignment

    @waahm7
    waahm7 committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    68521d9 View commit details
    Browse the repository at this point in the history

  5. Fix the object range to remain 'not satisfiable' even with alignment.

    @waahm7
    waahm7 committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    d7ca4b4 View commit details
    Browse the repository at this point in the history

  6. Fix bug where response body can be greator than part_size in case of … 

    …error
    @waahm7
    waahm7 committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    ff2ca61 View commit details
    Browse the repository at this point in the history

  7. remove invalid range

    @waahm7
    waahm7 committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    7270195 View commit details
    Browse the repository at this point in the history

  8. remove alignment and fix etag in case of first_part_size_mismatch

    @waahm7
    waahm7 committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    2f1e084 View commit details
    Browse the repository at this point in the history

  9. Update source/s3_auto_ranged_get.c 

    Co-authored-by: Michael Graeb <graebm@amazon.com>
    @waahm7 @graebm
    waahm7 and graebm authored Dec 26, 2023
    Configuration menu
    Copy the full SHA
    4edd1c1 View commit details
    Browse the repository at this point in the history

  10. Update source/s3_auto_ranged_get.c 

    Co-authored-by: Michael Graeb <graebm@amazon.com>
    @waahm7 @graebm
    waahm7 and graebm authored Dec 26, 2023
    Configuration menu
    Copy the full SHA
    1e77d70 View commit details
    Browse the repository at this point in the history

  11. Update comment

    @waahm7
    waahm7 committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    424c939 View commit details
    Browse the repository at this point in the history

  12. refactor parsing function

    @waahm7
    waahm7 committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    49c38e4 View commit details
    Browse the repository at this point in the history

  13. Fix in test as well

    @waahm7
    waahm7 committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    e60efc3 View commit details
    Browse the repository at this point in the history

  14. remove unused variable

    @waahm7
    waahm7 committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    28db482 View commit details
    Browse the repository at this point in the history

  15. PR Feedback

    @waahm7
    waahm7 committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    254a152 View commit details
    Browse the repository at this point in the history

  16. Add test for empty file with range case

    @waahm7
    waahm7 committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    9ca78cf View commit details
    Browse the repository at this point in the history

  17. Rename variables

    @waahm7
    waahm7 committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    0c0cc98 View commit details
    Browse the repository at this point in the history

  18. Update comments

    @waahm7
    waahm7 committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    b077d39 View commit details
    Browse the repository at this point in the history

  19. Fix another bug

    @waahm7
    waahm7 committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    093945c View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. Merge branch 'refactor-empty-file' into refactor-ranged-get-object 

    # Conflicts:
#	source/s3_auto_ranged_get.c
    @waahm7
    waahm7 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    f2dfa19 View commit details
    Browse the repository at this point in the history

  2. remove space

    @waahm7
    waahm7 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    0c101b7 View commit details
    Browse the repository at this point in the history

  3. comment cleanup

    @waahm7
    waahm7 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    7b703a0 View commit details
    Browse the repository at this point in the history

  4. Remove bytes=-0 test

    @waahm7
    waahm7 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    aababa8 View commit details
    Browse the repository at this point in the history

  5. Update log

    @waahm7
    waahm7 committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    5ef1b80 View commit details
    Browse the repository at this point in the history