Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in aws_cached_signing_config_new #358

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Fix typo in aws_cached_signing_config_new #358

merged 1 commit into from
Oct 20, 2023

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Oct 20, 2023

Issue #, if available:
#357
Description of changes:
Fixes a possible bad copy paste error where we check for service.len but assign signed_body_value.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@waahm7 waahm7 changed the title Fix typo Fix typo in aws_cached_signing_config_new Oct 20, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #358 (a87e0a4) into main (f710806) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   89.59%   89.59%           
=======================================
  Files          18       18           
  Lines        4893     4893           
=======================================
  Hits         4384     4384           
  Misses        509      509           
Files Coverage Δ
source/s3_util.c 98.67% <100.00%> (ø)

@waahm7 waahm7 merged commit 684484e into main Oct 20, 2023
30 checks passed
@waahm7 waahm7 deleted the fix_bad_copypaste branch October 20, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants