Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 1 array for part info, instead of separate etag array and checksum array #322

Merged
merged 7 commits into from
Jun 30, 2023

Conversation

graebm
Copy link
Contributor

@graebm graebm commented Jun 30, 2023

Issue:
I wanted to track more info about each part. We already had separate arrays for the parts' etags and checksums, and the code to deal with them was always finicky since parts may arrive out of order and the array-list API is clunky.

Description of changes:
Use a single array-list to track all part info, instead of separate arrays for etags, checksums, size, etc

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023

Codecov Report

Merging #322 (1766f7d) into main (28f7b87) will decrease coverage by 0.01%.
The diff coverage is 96.42%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
- Coverage   88.88%   88.87%   -0.01%     
==========================================
  Files          17       17              
  Lines        4947     4943       -4     
==========================================
- Hits         4397     4393       -4     
  Misses        550      550              
Impacted Files Coverage Δ
source/s3_client.c 88.02% <ø> (ø)
source/s3_auto_ranged_put.c 92.15% <95.00%> (-0.10%) ⬇️
source/s3_copy_object.c 81.27% <100.00%> (+0.44%) ⬆️
source/s3_request_messages.c 74.76% <100.00%> (-0.12%) ⬇️

source/s3_auto_ranged_put.c Outdated Show resolved Hide resolved
source/s3_auto_ranged_put.c Show resolved Hide resolved
include/aws/s3/private/s3_copy_object.h Show resolved Hide resolved
source/s3_auto_ranged_put.c Outdated Show resolved Hide resolved
source/s3_auto_ranged_put.c Outdated Show resolved Hide resolved
@graebm graebm merged commit 8dd4dd6 into main Jun 30, 2023
29 checks passed
@graebm graebm deleted the part-list branch June 30, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants