Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build broken since #360 #378

Closed
snickl opened this issue Nov 22, 2023 · 5 comments
Closed

Build broken since #360 #378

snickl opened this issue Nov 22, 2023 · 5 comments
Labels
bug Something isn't working p2 This is a standard priority issue

Comments

@snickl
Copy link

snickl commented Nov 22, 2023

Describe the bug

#360 introduced AWS_ERROR_HTTP_RESPONSE_FIRST_BYTE_TIMEOUT and others, which aren't defined

Expected Behavior

Package compiles

Current Behavior

Does not compile

Reproduction Steps

Compile package

Possible Solution

No response

Additional Information/Context

No response

aws-c-s3 version used

0.3.23..0.4.0

Compiler and version used

gcc 12

Operating System and version

debian 11 / buildroot 2023.08

@snickl snickl added bug Something isn't working needs-triage This issue or PR still needs to be triaged. labels Nov 22, 2023
@jmklix
Copy link
Member

jmklix commented Nov 22, 2023

Can you provide more details about this? What errors are you seeing when you try to build? and what steps are you using to build?

@jmklix jmklix added p2 This is a standard priority issue response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. labels Nov 22, 2023
@waahm7
Copy link
Contributor

waahm7 commented Nov 22, 2023

You need to ensure that the dependencies (aws-c-* packages like aws-c-http, aws-c-common, etc.) are also updated to the latest version.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Nov 22, 2023
@snickl
Copy link
Author

snickl commented Nov 22, 2023

I'm packaging aws-iot-device-sdk-cpp-v2 and aws-iot-fleetwise-edge for buildroot, using the latest versions of each package as I've moved down the dependency chain.
It seems the cmake package dependencies are all satisfied, and I haven't seen a missing header error.
What package/header is supposed to provide AWS_ERROR_HTTP_RESPONSE_FIRST_BYTE_TIMEOUT et.al.?

@DmitriyMusatkin
Copy link
Contributor

AWS_ERROR_HTTP_RESPONSE_FIRST_BYTE_TIMEOUT should be defined in the latest release of aws-c-http

@snickl
Copy link
Author

snickl commented Nov 22, 2023

AWS_ERROR_HTTP_RESPONSE_FIRST_BYTE_TIMEOUT should be defined in the latest release of aws-c-http

You're right. So there's at least one package I must have missed when switching on release notifications...

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

4 participants