Remove non portable use of pthread_t #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on awslabs/aws-c-common#563 |
nchong-at-aws
commented
Dec 19, 2019
danielsn
previously requested changes
Dec 19, 2019
- Rename `aws_thread_id` to `aws_thread_id_t` - Re-use `thread.thread_id` in destroy() to avoid pointer to stack var
danielsn
reviewed
Jan 3, 2020
graebm
approved these changes
Jan 3, 2020
* Update doc for event loop destroy API function to note requirements for thread-safety * (Hopefully) clearer thread var names and comments added to kqueue implementation * Use separate aws_thread_id_t var for thread_joined_to
|
Merging as an Admin because our CI jobs for github actions don't work with a forked PR, and our downstream builder checks "master" from s2n which is currently broken for gcc 4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #217
Description of changes:
Use portable thread id comparison functions from proposed c common changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.