Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip empty string for proxy env var #446

Merged
merged 2 commits into from
Jul 7, 2023
Merged

skip empty string for proxy env var #446

merged 2 commits into from
Jul 7, 2023

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Jul 6, 2023 •
edited
Loading

Issue #, if available:

Description of changes:

  • If the env var is set to empty, ignore it as it's unset.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

graebm
graebm approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder if we make this mistake in any other aws-c libraries?

@TingDaoK TingDaoK merged commit f800427 into main Jul 7, 2023
34 checks passed
@TingDaoK TingDaoK deleted the skip-empty-proxy-env branch July 7, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graebm graebm graebm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TingDaoK @graebm