Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing SOVERSION bump #913

Closed
stewartsmith opened this issue May 23, 2022 · 1 comment
Closed

Missing SOVERSION bump #913

stewartsmith opened this issue May 23, 2022 · 1 comment
Labels
needs-review This issue or pull request needs review from a core team member. p2 This is a standard priority issue third-party This issue is related to third-party libraries or applications.

Comments

@stewartsmith
Copy link

As we are needing to include aws-c-common in Amazon Linux in order to package AWS CLI v2, we need to ensure that the SOVERSION is being updated appropriately to avoid nasty build and runtime surprises.

When looking at the diff between v0.6.14 and v0.7.4, I noticed a couple of changes that should have come with an SOVERSION major or minor bump.

It looks like ee859bf should have introduced a minor bump as it added functionality.

The changes in 3eb3830#diff-e4e7fa2904589ee122e13b9546e13b80ef35e509aaa26fa8967ef3238d5533c9L119 appear to also indicate an ABI change, which would mean a major SOVERSION bump would be needed as well.

Am I misunderstanding these changes and their impact to shared library ABI?
@jmklix jmklix added third-party This issue is related to third-party libraries or applications. p2 This is a standard priority issue needs-review This issue or pull request needs review from a core team member. labels Sep 6, 2023
@jmklix
Copy link
Member

jmklix commented Jul 1, 2024

Sorry for the late reply. We have since bumped the version to v0.9.23. So I don't think this is a concern anymore. Please let me know if you have any questions about versioning with this sdk

@jmklix jmklix closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-review This issue or pull request needs review from a core team member. p2 This is a standard priority issue third-party This issue is related to third-party libraries or applications.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stewartsmith @jmklix