Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Math.h does not compile on MSVC #717

Closed
deejaweej opened this issue Oct 19, 2020 · 1 comment
Closed

Math.h does not compile on MSVC #717

deejaweej opened this issue Oct 19, 2020 · 1 comment
Assignees
@jmklix
Labels
bug This issue is a bug. needs-review This issue or pull request needs review from a core team member. p2 This is a standard priority issue

Comments

@deejaweej
Copy link

deejaweej commented Oct 19, 2020 •
edited
Loading

There are multiple mismatches between the header declarations and inline definitions on MSVC. See:
https://github.com/awslabs/aws-c-common/blob/master/include/aws/common/math.h#L74
https://github.com/awslabs/aws-c-common/blob/master/include/aws/common/math.msvc.inl#L70
@jmklix jmklix added bug This issue is a bug. p2 This is a standard priority issue needs-review This issue or pull request needs review from a core team member. labels Sep 21, 2023
@jmklix jmklix self-assigned this Sep 21, 2023
@TingDaoK
Copy link
Contributor

it has been fixed https://github.com/awslabs/aws-c-common/blob/main/include/aws/common/math.msvc.inl#L113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmklix jmklix

Labels
bug This issue is a bug. needs-review This issue or pull request needs review from a core team member. p2 This is a standard priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmklix @TingDaoK @deejaweej