Undefined behavior in byte_cursor_limit_tests

[jkuszmaul]

At

aws-c-common/tests/cursor_test.c

Line 233 in c27fcc8

ASSERT_TRUE(aws_byte_buf_write(&buffer, arr, 0));

in byte_cursor_limit_tests, aws_byte_buf_write is called after aws_byte_buf_clean_up(&buffer) (which I assume is intentional). This results in a call to memcpy with NULL pointer and a length of zero. This appears to be undefined behavior (see https://en.cppreference.com/w/c/string/byte/memcpy), and results in the test failing if I run it under clang's ubsan.

[TingDaoK]

https://github.com/awslabs/aws-c-common/blame/main/source/byte_buf.c#L1447-L1450

[jmklix]

This was fixed in the above commit. Closing this issue