Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIT license should be included in extra licenses file #1060

Closed
bkmgit opened this issue Sep 26, 2023 · 2 comments
Closed

MIT license should be included in extra licenses file #1060

bkmgit opened this issue Sep 26, 2023 · 2 comments
Assignees
Labels
documentation This is a problem with documentation. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.

Comments

@bkmgit
Copy link

bkmgit commented Sep 26, 2023

Describe the bug

The cJSON header from https://github.com/DaveGamble/cJSON is available under MIT license, and so should also be listed in the
THIRD-PARTY-LICENSE.txt file

Expected Behavior

THIRD-PARTY-LICENSES.txt should contain all third party license

Current Behavior

THIRD-PARTY-LICENSE.txt contains only one license, BSD-3-Clause

Reproduction Steps

Examine the file https://github.com/awslabs/aws-c-common/blob/main/THIRD-PARTY-LICENSES.txt

Possible Solution

Update the file https://github.com/awslabs/aws-c-common/blob/main/THIRD-PARTY-LICENSES.txt

Additional Information/Context

No response

aws-c-common version used

0.9.3

Compiler and version used

gcc 15

Operating System and version

Fedora 40 (rawhide)

@bkmgit bkmgit added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 26, 2023
@yasminetalby yasminetalby removed the needs-triage This issue or PR still needs to be triaged. label Sep 27, 2023
@yasminetalby yasminetalby self-assigned this Sep 27, 2023
@yasminetalby yasminetalby added documentation This is a problem with documentation. p2 This is a standard priority issue investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed bug This issue is a bug. investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Sep 27, 2023
@yasminetalby
Copy link
Contributor

Hello @bkmgit ,

Thank you very much for your submission. You are right cJSON header from DaveGamble/cJSON used here is under the MIT License (reference to their LICENSE file.
We do currently include their license at the top of our cJSON.c file.

I am not sure why it is not referred to in the THIRD-PARTY-LICENSE.txt .

I'll submit a fix for it.

Thank you very much for reporting this. We really appreciate your time and feedback!

Best regards,

Yasmine

@yasminetalby yasminetalby added the pending-release This issue will be fixed by an approved PR that hasn't been released yet. label Sep 27, 2023
@jmklix
Copy link
Member

jmklix commented Oct 18, 2023

License PR merge. Closing this issue

@jmklix jmklix closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.
Projects
None yet
Development

No branches or pull requests

3 participants