MAX_TIME_BETWEEN_REQUEST_RESPONSE can be changed by the user #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fommil
commented
Feb 23, 2023
| @@ -35,7 +35,7 @@ public class DiagnosticUtils { | |||
| public static void takeDelayedDeliveryActionIfRequired(String resourceIdentifier, Instant enqueueTimestamp, Logger log) { | |||
| final long durationBetweenEnqueueAndAckInMillis = Duration | |||
| .between(enqueueTimestamp, Instant.now()).toMillis(); | |||
| if (durationBetweenEnqueueAndAckInMillis > MAX_TIME_BETWEEN_REQUEST_RESPONSE / 3) { | |||
| if (durationBetweenEnqueueAndAckInMillis > 11000) { | |||
| // The above condition logs the warn msg if the delivery time exceeds 11 seconds. | |||
There was a problem hiding this comment.
note that the code in master is incorrect relative to the comment, since this triggers for 20 seconds not 11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1051
Description of changes:
MAX_TIME_BETWEEN_REQUEST_RESPONSEcan be changed by the user via a system property.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.