Clean up in-memory state of deleted kinesis stream in MultiStreamMode #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amazon-kinesis-client/src/test/java/software/amazon/kinesis/coordinator/SchedulerTest.java
Outdated
Show resolved
Hide resolved
amazon-kinesis-client/src/test/java/software/amazon/kinesis/coordinator/SchedulerTest.java
Show resolved
Hide resolved
...nt/src/main/java/software/amazon/kinesis/leases/dynamodb/DynamoDBLeaseManagementFactory.java
Show resolved
Hide resolved
...nt/src/main/java/software/amazon/kinesis/leases/dynamodb/DynamoDBLeaseManagementFactory.java
Show resolved
Hide resolved
...esis-client/src/main/java/software/amazon/kinesis/coordinator/DeletedStreamListProvider.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This change fixes the bug wherein in multi stream mode, if any particular stream is deleted in Kinesis it is cleaned from KCL's in-memory state. This reduces the recurring calls to Kinesis API's to try to get information about deleted stream which result in ResourceNotFoundException.
This increase calls are specifically affecting in case where we have deferred lease deletion mode.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.